Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778Ab3FZD0O (ORCPT ); Tue, 25 Jun 2013 23:26:14 -0400 Received: from terminus.zytor.com ([198.137.202.10]:50891 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380Ab3FZD0N (ORCPT ); Tue, 25 Jun 2013 23:26:13 -0400 User-Agent: K-9 Mail for Android In-Reply-To: References: <6c27e79870ec93f7a8c6692d4bcfebaee589fa6b.1372211451.git.dvhart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 8/8] pch_gbe: Add MinnowBoard support From: "H. Peter Anvin" Date: Tue, 25 Jun 2013 20:25:59 -0700 To: Bjorn Helgaas , Darren Hart CC: Linux Kernel Mailing List , Peter P Waskiewicz Jr , Andy Shevchenko , danders@circuitco.com, vishal.l.verma@intel.com, "David S. Miller" , netdev Message-ID: <68829d6a-a419-49a7-9df9-c9fa80f45aed@email.android.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3521 Lines: 83 The same subsystem (not subdevice!) ID is used for all devices on the Minnowboard itself. Bjorn Helgaas wrote: >On Tue, Jun 25, 2013 at 7:53 PM, Darren Hart >wrote: >> The MinnowBoard uses an AR803x PHY with the PCH GBE. >> >> It does not implement the RGMII 2ns TX clock delay in the trace >routing >> nor via strapping. Add a detection method for the board and the PHY >and >> enable the tx clock delay via the registers. >> >> This PHY will hibernate without link for 10 seconds. Ensure the PHY >is >> awake for probe and then disable hibernation. A future improvement >would >> be to convert pch_gbe to using PHYLIB and making sure we can wake the >> PHY at the necessary times rather than permanently disabling it. >> >> Use the MinnowBoard PCI subsystem ID to identify the board and setup >the >> appropriate callbacks in a new pci_id driver_data structure. >> >> Signed-off-by: Darren Hart >> Cc: "David S. Miller" >> Cc: "H. Peter Anvin" >> Cc: Peter Waskiewicz >> Cc: Andy Shevchenko >> Cc: netdev@vger.kernel.org >> --- >> drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 1 + >> drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 2 + >> .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 32 ++++++++ >> .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c | 89 >++++++++++++++++++++++ >> .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h | 2 + >> 5 files changed, 126 insertions(+) >> ... > >> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c >b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c >> index 6667a6b..6f0b9e3 100644 >> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c >> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c >>... >> +static struct pch_gbe_privdata pch_gbe_minnowboard_privdata = { >> + .phy_reset = minnow_phy_reset, >> + .phy_tx_clk_delay = pch_gbe_phy_tx_clk_delay, >> +}; >> + >> static DEFINE_PCI_DEVICE_TABLE(pch_gbe_pcidev_id) = { >> {.vendor = PCI_VENDOR_ID_INTEL, >> .device = PCI_DEVICE_ID_INTEL_IOH1_GBE, >> + .subvendor = PCI_VENDOR_ID_CIRCUITCO, >> + .subdevice = PCI_DEVICE_ID_CIRCUITCO_MINNOWBOARD, > >"MINNOWBOARD" seems like a pretty generic name for something that >probably refers only to the gigabit ethernet device in the EG20T. If >you expect to use that same subdevice ID on other devices, I guess we >can add PCI_DEVICE_ID_CIRCUITCO_MINNOWBOARD to pci_ids.h. If it will >only be used for the gigabit ethernet device, we would normally not >add a #define for it and would just use the hex constant here (see the >comment at the top of pci_ids.h). > >> + .class = (PCI_CLASS_NETWORK_ETHERNET << 8), >> + .class_mask = (0xFFFF00), >> + .driver_data = (unsigned long) &pch_gbe_minnowboard_privdata >> + }, >> + {.vendor = PCI_VENDOR_ID_INTEL, >> + .device = PCI_DEVICE_ID_INTEL_IOH1_GBE, >> .subvendor = PCI_ANY_ID, >> .subdevice = PCI_ANY_ID, >> .class = (PCI_CLASS_NETWORK_ETHERNET << 8), -- Sent from my mobile phone. Please excuse brevity and lack of formatting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/