Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751355Ab3FZEHo (ORCPT ); Wed, 26 Jun 2013 00:07:44 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:58420 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732Ab3FZEHl convert rfc822-to-8bit (ORCPT ); Wed, 26 Jun 2013 00:07:41 -0400 From: "Hebbar, Gururaja" To: "Fernandes, Joel" , Tony Lindgren , "Nori, Sekhar" , Matt Porter , "Grant Likely" , Rob Herring , Vinod Koul , Mark Brown , "Cousson, Benoit" , Russell King , Rob Landley , Andrew Morton , Jason Kridner , Koen Kooi , "Krishnamoorthy, Balaji T" , Chris Ball CC: Devicetree Discuss , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux Documentation List , Linux MMC List , Linux SPI Devel List , Arnd Bergmann Subject: RE: [PATCH 5/5] mmc: omap_hsmmc: Add reg-offset to bindings documentation Thread-Topic: [PATCH 5/5] mmc: omap_hsmmc: Add reg-offset to bindings documentation Thread-Index: AQHOcgwxbYUj9dwpPUuW5SjrhzTkVplHYJfw Date: Wed, 26 Jun 2013 04:06:31 +0000 Message-ID: <1BAFE6F6C881BF42822005164F1491C33EC43DB1@DBDE04.ent.ti.com> References: <1372209901-6715-1-git-send-email-joelagnel@ti.com> In-Reply-To: <1372209901-6715-1-git-send-email-joelagnel@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2070 Lines: 51 On Wed, Jun 26, 2013 at 06:55:01, Fernandes, Joel wrote: > From: Joel A Fernandes > > A new reg-offset property was added to account for register offsets > in some omap-hsmmc's. Document the new property. > Small nitpick I usually get feedback that any driver DT changes and the associated Binding doc update should come in one single patch for better readability. In this case, I believe it would be patch 1/5 & 5/5 Regards, Gururaja > Signed-off-by: Joel A Fernandes > --- > .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > index 8c8908a..33f4b1e 100644 > --- a/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > +++ b/Documentation/devicetree/bindings/mmc/ti-omap-hsmmc.txt > @@ -20,6 +20,9 @@ ti,dual-volt: boolean, supports dual voltage cards > ti,non-removable: non-removable slot (like eMMC) > ti,needs-special-reset: Requires a special softreset sequence > ti,needs-special-hs-handling: HSMMC IP needs special setting for handling High Speed > +reg-offset: Supplementing the common reg property (described in bindings/mmc/mmc.txt), > +some omap-hsmmc's can start an offset from reg but are otherwise identical to others. > +The registers between start to offset are considered reserved. > dmas: List of DMA specifiers with the controller specific format > as described in the generic DMA client binding. A tx and rx > specifier is required. > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/