Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752491Ab3FZJKx (ORCPT ); Wed, 26 Jun 2013 05:10:53 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:46541 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994Ab3FZJKv (ORCPT ); Wed, 26 Jun 2013 05:10:51 -0400 Date: Wed, 26 Jun 2013 10:10:33 +0100 From: Russell King - ARM Linux To: Greg KH Cc: Oliver Schinagl , Maxime Ripard , arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com, linus.walleij@linaro.org, linux-sunxi@googlegroups.com, Oliver Schinagl Subject: Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses Message-ID: <20130626091032.GE2718@n2100.arm.linux.org.uk> References: <1371502778-15849-1-git-send-email-oliver+list@schinagl.nl> <1371502778-15849-2-git-send-email-oliver+list@schinagl.nl> <20130617225847.GA9494@kroah.com> <20130624092942.GG26008@lukather> <20130624160440.GA15201@kroah.com> <51C87DC7.50005@schinagl.nl> <20130624181509.GA8847@kroah.com> <51C8B84C.3020200@schinagl.nl> <20130624214615.GA17604@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130624214615.GA17604@kroah.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 26 On Mon, Jun 24, 2013 at 02:46:15PM -0700, Greg KH wrote: > Stick with a binary attribute, and attach that to the proper class > structure and all should be fine. > > Ah crap, you're using a platform device. > > {sigh} > > Why? Why not use a "real" device which has a "real" class, and then use > the interfaces there? And why aren't platform devices "real" devices? If platform devices are second class devices then that's pretty crap because virtually all devices on ARM are platform devices, not something like "first class" PCI devices. We could make them PCI devices if you want us to totally fsck with the PCI code to bend it in ways it was never meant to, but I suspect that'll upset the PCI guys. No, platform devices must be first class devices just like any other. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/