Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752246Ab3FZJPd (ORCPT <rfc822;w@1wt.eu>);
	Wed, 26 Jun 2013 05:15:33 -0400
Received: from mx1.redhat.com ([209.132.183.28]:12283 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751347Ab3FZJPb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 26 Jun 2013 05:15:31 -0400
Date: Wed, 26 Jun 2013 11:13:46 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Namhyung Kim <namhyung.kim@lge.com>,
        Peter Zijlstra <peterz@infradead.org>, "mingo@elte.hu" <mingo@elte.hu>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        David Ahern <dsahern@gmail.com>
Subject: Re: [BUG] perf report: garbage output with event grouping
Message-ID: <20130626091346.GB1019@krava.brq.redhat.com>
References: <CABPqkBQ843gUmk596NrOyybBH63o02sz8-8qW0jOkEodrs1a7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CABPqkBQ843gUmk596NrOyybBH63o02sz8-8qW0jOkEodrs1a7g@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2327
Lines: 57

On Wed, Jun 26, 2013 at 10:42:49AM +0200, Stephane Eranian wrote:
> Hi,
> 
> 
> $ perf record -e 'cpi{cycles,instructions}' noploop 5
> 
> $ perf report --stdio --group
> # group: ^P^Q<A0>\{cycles,instructions}
> # ========
> #
> # Samples: 39K of event '^P^Q<A0>\ { cycles, instructions }'
> # Event count (approx.): 37782563692
> #
> #         Overhead  Command      Shared Object                       Symbol
> # ................  .......  .................  ...........................
> #
>     99.91%  99.98%  noploop  noploop            [.] main
>      0.06%   -nan%  noploop  [kernel.kallsyms]  [k] read_hpet
>      0.01%   0.01%  noploop  [kernel.kallsyms]  [k] __acct_update_integrals
>      0.01%   -nan%  noploop  [kernel.kallsyms]  [k] raise_softirq
>      0.01%   -nan%  noploop  [kernel.kallsyms]  [k] apic_timer_interrupt
>      0.01%   -nan%  noploop  [kernel.kallsyms]  [k] __do_softirq
>      0.01%   -nan%  noploop  [kernel.kallsyms]  [k] common_interrupt
>      0.00%   0.00%  noploop  [kernel.kallsyms]  [k] intel_pmu_enable_all
>      0.00%   0.01%  noploop  [kernel.kallsyms]  [k] cpuacct_account_field
>      0.00%   0.01%  noploop  [kernel.kallsyms]  [k] __local_bh_enable
> 
> 
> 1. The group name is garbage if not anonymous group.
> 2. arithmetic error in the overhead columns leading to NaN.
> 3. I assume the Overhead column order is the group event order. Is that right?

hi

1) attached patch fixies that for me
2) I cannot reproduce this one on acme's tree
3) right, and we do need event names there ;-)

---
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 738d3b8..673d98c 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -2089,7 +2089,7 @@ static int process_group_desc(struct perf_file_section *section __maybe_unused,
 			evsel->leader = evsel;
 			/* {anon_group} is a dummy name */
 			if (strcmp(desc[i].name, "{anon_group}"))
-				evsel->group_name = desc[i].name;
+				evsel->group_name = strdup(desc[i].name);
 			evsel->nr_members = desc[i].nr_members;
 
 			if (i >= nr_groups || nr > 0) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/