Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752414Ab3FZMHT (ORCPT ); Wed, 26 Jun 2013 08:07:19 -0400 Received: from mail-wg0-f54.google.com ([74.125.82.54]:59544 "EHLO mail-wg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751992Ab3FZMHR (ORCPT ); Wed, 26 Jun 2013 08:07:17 -0400 MIME-Version: 1.0 In-Reply-To: <51CAD7E4.2000403@ti.com> References: <1368688257-18705-1-git-send-email-prabhakar.csengg@gmail.com> <1368688257-18705-3-git-send-email-prabhakar.csengg@gmail.com> <51CAD305.30407@ti.com> <51CAD7E4.2000403@ti.com> From: Prabhakar Lad Date: Wed, 26 Jun 2013 17:36:56 +0530 Message-ID: Subject: Re: [PATCH 2/2] video:da8xx-fb: Convert to devm_* api To: Tomi Valkeinen Cc: "Etheridge, Darren" , DLOS , LFBDEV , Florian Tobias Schandinat , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1648 Lines: 48 Hi Tomi, On Wed, Jun 26, 2013 at 5:30 PM, Tomi Valkeinen wrote: > On 26/06/13 14:56, Prabhakar Lad wrote: >> Hi Tomi, >> >> On Wed, Jun 26, 2013 at 5:09 PM, Tomi Valkeinen wrote: >>> On 16/05/13 10:10, Lad Prabhakar wrote: >>>> From: Lad, Prabhakar >>>> >>>> Use devm_ioremap_resource instead of reques_mem_region()/ioremap() and >>>> devm_request_irq() instead of request_irq(). >>>> >>>> This ensures more consistent error values and simplifies error paths. >>>> >>>> Signed-off-by: Lad, Prabhakar >>>> --- >>>> drivers/video/da8xx-fb.c | 39 +++++++-------------------------------- >>>> 1 files changed, 7 insertions(+), 32 deletions(-) >>> >>> There's something similar in Darren's da8xx-fb series. Can you check if >>> there are differences? >>> >> I don't see similar changes in his patch series. > > [PATCH 14/23] video: da8xx-fb: use devres > Oops missed it out :), patch is almost similar except for following block, - fb_clk = clk_get(&device->dev, "fck"); + fb_clk = devm_clk_get(&device->dev, "fck"); if (IS_ERR(fb_clk)) { dev_err(&device->dev, "Can not get device clock\n"); - ret = -ENODEV; - goto err_ioremap; + return -ENODEV; } How do you suggest to handle it ? Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/