Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751541Ab3FZMqv (ORCPT ); Wed, 26 Jun 2013 08:46:51 -0400 Received: from mga14.intel.com ([143.182.124.37]:22874 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269Ab3FZMqu (ORCPT ); Wed, 26 Jun 2013 08:46:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,944,1363158000"; d="scan'208";a="260396834" From: Alexander Shishkin To: Felipe Balbi , George Cherian Cc: balbi@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, linux-omap@vger.kernel.org, Kishon Vijay Abraham I , Alan Stern , mgr@pengutronix.de Subject: Re: [PATCH] usb: dwc3: core: continue probe even if usb3 phy is not available In-Reply-To: <20130626121210.GA12640@arwen.pp.htv.fi> References: <1372238954-29047-1-git-send-email-george.cherian@ti.com> <20130626101647.GT12640@arwen.pp.htv.fi> <51CAD977.6040309@ti.com> <20130626121210.GA12640@arwen.pp.htv.fi> User-Agent: Notmuch/0.15.2+182~gd0bd88f (http://notmuchmail.org) Emacs/23.4.1 (x86_64-pc-linux-gnu) Date: Wed, 26 Jun 2013 15:46:45 +0300 Message-ID: <874nclghu2.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2628 Lines: 74 Felipe Balbi writes: > On Wed, Jun 26, 2013 at 05:37:19PM +0530, George Cherian wrote: >> On 6/26/2013 3:46 PM, Felipe Balbi wrote: >> >Hi, >> > >> >On Wed, Jun 26, 2013 at 02:59:14PM +0530, George Cherian wrote: >> >>There can be configurations in which DWC3 is hoooked up only to USB2 PHY. >> >>In such cases we should not return -EPROBE_DEFER, rather continue probe >> >>even if there is no USB3 PHY. >> >> >> >>Signed-off-by: George Cherian >> >>--- >> >> drivers/usb/dwc3/core.c | 31 ++++++++++++++++++++++++------- >> >> 1 file changed, 24 insertions(+), 7 deletions(-) >> >> >> >>diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c >> >>index c35d49d..d5e6f3e 100644 >> >>--- a/drivers/usb/dwc3/core.c >> >>+++ b/drivers/usb/dwc3/core.c >> >>@@ -100,7 +100,9 @@ static void dwc3_core_soft_reset(struct dwc3 *dwc) >> >> dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg); >> >> usb_phy_init(dwc->usb2_phy); >> >>- usb_phy_init(dwc->usb3_phy); >> >>+ >> >>+ if (dwc->usb3_phy) >> >>+ usb_phy_init(dwc->usb3_phy); >> >I would feel more comfortable if you would move our maximum_speed module >> >parameter to DT with a property such as: >> > >> >snps,maximum_speed = "highspeed"; >> > >> >then on driver you could: >> okay >> >ret = of_property_read_string(np, "snps,maximum_speed", &maximum_speed); >> >if (ret < 0) >> > bailout(); >> > >> >if (strncmp(maximum_speed, "superspeed", 10) == 0) { >> > /* grab USB3 PHY, return EPROBE_DEFER if not found */ >> > grab_usb3_phy(); >> >} >> > >> >if ((strncmp(maximum_speed, "highspeed", 9) == 0) || >> > (strncmp(maximum_speed, "fullspeed", 9) == 0) || >> > (strncmp(maximum_speed, "lowspeed", 8) == 0)) { >> > /* grab USB2 PHY, return EPROBE_DEFER if not found */ >> > grab_usb2_phy(); >> >} >> > >> >this way, we depend solely on setting maximum_speed to highspeed for >> >AM437x :-) >> In dra7xx one instance is superspeed and one instance highspeed. > > right, but in DT you will define both instances and each instance will > have a seaparate snps,maximum_speed attribute :-) > > I'm now considering if we should make maximum_speed a generic attribute, > Kishon ? Alex ? Alan ? > > anyone else needs such thing ? We have a force-full-speed attibute for chipidea on the way. This maximum_speed looks like a more generic alternative. Michael, what say you? Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/