Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752304Ab3FZPD0 (ORCPT ); Wed, 26 Jun 2013 11:03:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51281 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752256Ab3FZPDY (ORCPT ); Wed, 26 Jun 2013 11:03:24 -0400 Date: Wed, 26 Jun 2013 08:04:07 -0700 From: Greg Kroah-Hartman To: Mika Westerberg Cc: Jesse Barnes , Bjorn Helgaas , "Rafael J. Wysocki" , Yinghai Lu , john.ronciak@intel.com, miles.j.penner@intel.com, bruce.w.allan@intel.com, "Kirill A. Shutemov" , Heikki Krogerus , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges Message-ID: <20130626150407.GB14117@kroah.com> References: <1372177330-28013-1-git-send-email-mika.westerberg@linux.intel.com> <1372177330-28013-7-git-send-email-mika.westerberg@linux.intel.com> <20130625141556.2f9de7b1@jbarnes-desktop> <20130626121757.GP9294@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130626121757.GP9294@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 34 On Wed, Jun 26, 2013 at 03:17:57PM +0300, Mika Westerberg wrote: > On Tue, Jun 25, 2013 at 02:15:56PM -0700, Jesse Barnes wrote: > > On Tue, 25 Jun 2013 19:22:10 +0300 > > Mika Westerberg wrote: > > > > > + if (!(pci_probe & PCI_NOASSIGN_ROMS)) { > > > + pr_info("Thunderbolt host router detected disabling ROMs\n"); > > > + pci_probe |= PCI_NOASSIGN_ROMS; > > > + } > > > > I wonder if this should just be the default on x86? Or do we allocate > > ROM space to address some other platform where we need it and the BIOS > > doesn't do it for the devices we care about? > > Good question. In our case it definitely helps to have pci=norom the > default. Can't tell if it might break something that depends on the current > behaviour. > > Bjorn, Greg, Rafael, > > What do you think? I can't recall any specific reason to not do this, so no objection from me, but make it a nice and small patch that can easily be reverted if problems show up in the wild :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/