Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752852Ab3FZRvN (ORCPT ); Wed, 26 Jun 2013 13:51:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53535 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752438Ab3FZRvL (ORCPT ); Wed, 26 Jun 2013 13:51:11 -0400 Date: Wed, 26 Jun 2013 10:51:10 -0700 From: Greg KH To: Russell King - ARM Linux Cc: Oliver Schinagl , Maxime Ripard , arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, andy.shevchenko@gmail.com, linus.walleij@linaro.org, linux-sunxi@googlegroups.com, Oliver Schinagl Subject: Re: [PATCH 1/2] Initial support for Allwinner's Security ID fuses Message-ID: <20130626175110.GB2222@kroah.com> References: <1371502778-15849-1-git-send-email-oliver+list@schinagl.nl> <1371502778-15849-2-git-send-email-oliver+list@schinagl.nl> <20130617225847.GA9494@kroah.com> <20130624092942.GG26008@lukather> <20130624160440.GA15201@kroah.com> <51C87DC7.50005@schinagl.nl> <20130624181509.GA8847@kroah.com> <51C8B84C.3020200@schinagl.nl> <20130624214615.GA17604@kroah.com> <20130626091032.GE2718@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130626091032.GE2718@n2100.arm.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 40 On Wed, Jun 26, 2013 at 10:10:33AM +0100, Russell King - ARM Linux wrote: > On Mon, Jun 24, 2013 at 02:46:15PM -0700, Greg KH wrote: > > Stick with a binary attribute, and attach that to the proper class > > structure and all should be fine. > > > > Ah crap, you're using a platform device. > > > > {sigh} > > > > Why? Why not use a "real" device which has a "real" class, and then use > > the interfaces there? > > And why aren't platform devices "real" devices? If platform devices are > second class devices then that's pretty crap because virtually all > devices on ARM are platform devices, not something like "first class" > PCI devices. Ok, they are "real" devices, I'm just tired of seeing people throw everything and the kitchen sink into them, don't you agree? > We could make them PCI devices if you want us to totally fsck with the > PCI code to bend it in ways it was never meant to, but I suspect that'll > upset the PCI guys. > > No, platform devices must be first class devices just like any other. I was wrong, they can, and do, support default attribute groups, it's just that it seems no one uses them (or if they did, my greping can't find them...) So they are "first class" devices, my mistake. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/