Subject: [PATCH] 2.4: get_pid() typo fix
From: Robert Love <rml@tech9.net>
To: marcelo@conectiva.com.br
Cc: linux-kernel@vger.kernel.org
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: 06 Oct 2002 15:44:59 -0400
Message-Id: <1033933500.11402.4466.camel@phantasy>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1348
Lines: 42

Magnificent Marcelo,

Fix a typo in the comment of getpid() - we return current->tgid these
days, not current->pid.  Additionally, add some new comments explaining
exactly why we return the tgid and how this works.

Patch is against 2.4.20-pre9, please apply.

	Robert Love

diff -urN linux-2.4.20-pre9/kernel/timer.c linux/kernel/timer.c
--- linux-2.4.20-pre9/kernel/timer.c	2002-10-06 14:57:20.000000000 -0400
+++ linux/kernel/timer.c	2002-10-06 15:03:31.000000000 -0400
@@ -740,10 +740,18 @@
  * The Alpha uses getxpid, getxuid, and getxgid instead.  Maybe this
  * should be moved into arch/i386 instead?
  */
- 
+
+/**
+ * sys_getpid - return the thread group id of the current process
+ *
+ * Note, despite the name, this returns the tgid not the pid.  The tgid and
+ * the pid are identical unless CLONE_THREAD was specified on clone() in
+ * which case the tgid is the same in all threads of the same group.
+ *
+ * This is SMP safe as current->tgid does not change.
+ */
 asmlinkage long sys_getpid(void)
 {
-	/* This is SMP safe - current->pid doesn't change */
 	return current->tgid;
 }
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/