Date: Wed, 26 Jun 2013 18:41:34 -0400
From: Greg Price <price@MIT.EDU>
To: Namhyung Kim <namhyung.kim@lge.com>, Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
        Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
        David Ahern <dsahern@gmail.com>, Pekka Enberg <penberg@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf report: Add option to collapse undesired parts of
 call graph
Message-ID: <20130626224134.GA22203@biohazard-cafe.mit.edu>
References: <20121207072726.GY22203@biohazard-cafe.mit.edu>
 <20130111052736.GG3054@ghostprotocols.net>
 <20130623031720.GW22203@biohazard-cafe.mit.edu>
 <20130623215327.GA995@krava.redhat.com>
 <20130624083253.GA28025@gmail.com>
 <20130624231426.GY22203@biohazard-cafe.mit.edu>
 <20130625074734.GD11420@gmail.com>
 <51C94E6B.6000802@lge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51C94E6B.6000802@lge.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1558
Lines: 40

Hi Namhyung, hi Ingo,

On Tue, Jun 25, 2013 at 05:01:47PM +0900, Namhyung Kim wrote:
> >>TBH I'm not really familiar with the GTK front-end, as I mainly use
> >>the TUI.  At a quick trial, it looks like --blackbox has the expected
> >>effect on the display there; though with or without --blackbox I can't
> >>seem to get the entries to expand to show me a call-graph profile, so
> >>it's hard to demonstrate it fully.  Not sure what I may have done
> >>wrong in building or running perf to make that not work (or is that
> >>expected?)
> 
> Currently perf GTK front-end does not support callchains at all.
> There's a floating patchset to enable it though.
> 
> https://lkml.org/lkml/2013/6/4/181

OK, good to know I didn't simply mess something up.  So probably best
to leave any specific --blackbox-related support aside until that
patchset lands.


> >>What changes do you have in mind to make these available in the GTK
> >>front-end?
> >
> >I was thinking of something obvious like right-clicking it to make that
> >function back boxed away or so? Have no firm ideas - maybe the GTK gents
> >on Cc: know how to best integrate such features.
> 
> We don't support context menu yet.  Frankly, perf GTK code is still
> premature and needs some love.  Any contribution should be welcomed!

Noted.

Cheers,
Greg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/