Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071Ab3F0A2g (ORCPT ); Wed, 26 Jun 2013 20:28:36 -0400 Received: from 100.204.216.81.static.g-hkn.siw.siwnet.net ([81.216.204.100]:53616 "EHLO iko.pp.se" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752197Ab3F0A2f (ORCPT ); Wed, 26 Jun 2013 20:28:35 -0400 Message-Id: <201306270028.r5R0SNop031909@eskarina.iko.pp.se> X-Face: ^"+mumOlNwo;yI>`\39\txuVze?eiR9uqpo2*mE!9MWXgXI0v(3ArwymNWe'.q:eLl!=guD x{jGFEWN6,#HoN%2qRW;7.CL]9%Ap,067"u1%!NUqS.MhV'+,6$Fj-;W2Z}Y,JUZ'L+f)|B@3k3n;gLl*#i[(J-os#fNnDJ8m["|JWNwpORh|_.MGkR#|a~QS!"4hEQ{O{[Ii14{xD PU/:5wuv7m1=TK=.>G8wdfpY~]{H(Qa\1`%|Hz:!)c3f9UOW|WgE"4d\E7?oDu9. From: Anders Hammarquist To: Greg Kroah-Hartman cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [ 17/17] USB: serial: ti_usb_3410_5052: new device id for Abbot strip port cable In-Reply-To: Message from Greg Kroah-Hartman of "Wed, 26 Jun 2013 10:21:22 -0700." <20130626172122.GB14661@kroah.com> References: <20130625183915.443950649@linuxfoundation.org> <20130625183917.373592561@linuxfoundation.org> <201306252139.r5PLdQpP017104@eskarina.iko.pp.se><20130626172122.GB14661@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <31907.1372292903.1@eskarina.iko.pp.se> Date: Thu, 27 Jun 2013 02:28:23 +0200 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.3.9 (iko.pp.se [127.0.0.1]); Thu, 27 Jun 2013 02:28:25 +0200 (MEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1537 Lines: 36 In a message of Wed, 26 Jun 2013 10:21:22 -0700, Greg Kroah-Hartman writes: >On Tue, Jun 25, 2013 at 11:39:26PM +0200, Anders Hammarquist wrote: >> In a message of Tue, 25 Jun 2013 11:39:32 -0700, Greg Kroah-Hartman writes: >> >3.0-stable review patch. If anyone has any objections, please let me know. >> > >> >From: Anders Hammarquist >> > >> >commit 35a2fbc941accd0e9f1bfadd669311786118d874 upstream. >> > >> >Add product id for Abbott strip port cable for Precision meter which >> >uses the TI 3410 chip. >> >> Given the statically sized arrays, I think this patch should not go in >> alone. It needs to go together with the later patches I sent you that >> fix the array sizing. >> >> (this applies to all trees) > >Yes, but, thanks to the fact that you are only adding one more device >id, I don't think we are overflowing anything with this patch alone, >right? The only "bad" thing that could happen here is if a user >specifies a device/vendor id on the module command line, is it would >replace the device id you added, so all should be fine. > >Or am I reading the code wrong? I'm reading the code the same way you are. From what I can see there is no place that counts on there enough space beyond the last entry, so nothing truly bad should happen. /Anders -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/