Message-ID: <51CBF155.9050605@intel.com>
Date: Thu, 27 Jun 2013 11:01:25 +0300
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki 
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
MIME-Version: 1.0
To: Namhyung Kim <namhyung@kernel.org>
CC: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 09/15] perf tools: validate perf event header size
References: <1372079772-20803-1-git-send-email-adrian.hunter@intel.com> <1372079772-20803-10-git-send-email-adrian.hunter@intel.com> <87wqph1w8x.fsf@sejong.aot.lge.com>
In-Reply-To: <87wqph1w8x.fsf@sejong.aot.lge.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 728
Lines: 20

On 26/06/13 04:44, Namhyung Kim wrote:
> Hi Adrian,
> 
> On Mon, 24 Jun 2013 16:16:06 +0300, Adrian Hunter wrote:
>> 'size' includes the header so must be at least
>> 'sizeof(struct perf_event_header)'.  Error out
>> immediately if that is not the case.  Also
> 
> Just out of curiosity.
> 
> Do you have an experience it really matters?  AFAICS such an invalid
> sample should be detected during sample processing.

The patch was written a long time ago so I don't remember sorry.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/