Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753774Ab3F0NHn (ORCPT ); Thu, 27 Jun 2013 09:07:43 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:45526 "EHLO mail-oa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503Ab3F0NHg convert rfc822-to-8bit (ORCPT ); Thu, 27 Jun 2013 09:07:36 -0400 MIME-Version: 1.0 In-Reply-To: <6743122.cV0P3hQa28@vostro.rjw.lan> References: <1372331314-31010-1-git-send-email-naresh.bhat@linaro.org> <6743122.cV0P3hQa28@vostro.rjw.lan> Date: Thu, 27 Jun 2013 18:37:35 +0530 Message-ID: Subject: Re: [PATCH] ACPI/fan: Initialize acpi_state variable From: Naresh Bhat To: "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, len.brown@intel.com, patches@linaro.org, linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 48 Hi Rafael, You mean I need to initialize using ACPI_STATE_D0 ? and resend the patch ? Thanks -Naresh Bhat On 27 June 2013 17:58, Rafael J. Wysocki wrote: > On Thursday, June 27, 2013 04:38:34 PM naresh.bhat@linaro.org wrote: >> From: Naresh Bhat >> >> CC drivers/acpi/fan.o >> drivers/acpi/fan.c: In function ?fan_get_cur_state?: >> drivers/acpi/fan.c:96:9: warning: ?acpi_state? may be used uninitialized in this function [-Wuninitialized] >> --- >> drivers/acpi/fan.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c >> index f815da8..f61f7fd 100644 >> --- a/drivers/acpi/fan.c >> +++ b/drivers/acpi/fan.c >> @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long >> { >> struct acpi_device *device = cdev->devdata; >> int result; >> - int acpi_state; >> + int acpi_state = 0; > > Please use an appropriate symbol here. > >> >> if (!device) >> return -EINVAL; >> > > Thanks, > Rafael > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/