Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753446Ab3F0QlP (ORCPT ); Thu, 27 Jun 2013 12:41:15 -0400 Received: from merlin.infradead.org ([205.233.59.134]:33071 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024Ab3F0QlN (ORCPT ); Thu, 27 Jun 2013 12:41:13 -0400 Message-ID: <51CC6B09.5080809@infradead.org> Date: Thu, 27 Jun 2013 09:40:41 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Xiong Zhou CC: Ben Hutchings , matthew.garrett@nebula.com, platform-driver-x86@vger.kernel.org, Linux-Next , "linux-kernel@vger.kernel.org" , Stephen Rothwell , jim.epost@gmail.com Subject: Re: [PATCH]amilo-rfkill: add depends on i8042 in Kconfig References: <1371560680.3495.121.camel@deadeye.wl.decadent.org.uk> <51C07608.2070406@infradead.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2074 Lines: 70 On 06/18/13 18:09, Xiong Zhou wrote: > 2013/6/18 Randy Dunlap : >> On 06/18/13 06:04, Ben Hutchings wrote: >>> On Tue, 2013-06-18 at 17:21 +0800, Xiong Zhou wrote: >>>> From: Xiong Zhou >>>> >>>> Fix randconfig build failure for Amilo x86 platform driver. >>>> AMILO_RFKILL requires SERIO_I8042 being available. >>>> >>>> amilo-rfkill.c:(.text+0x108b5b): undefined reference to `i8042_lock_chip' >>>> amilo-rfkill.c:(.text+0x108b69): undefined reference to `i8042_command' >>>> amilo-rfkill.c:(.text+0x108b71): undefined reference to `i8042_unlock_chip' >>>> >>>> Reported-by: Jim Davis >>>> Signed-off-by: Xiong Zhou >>> >>> Acked-by: Ben Hutchings >>> >>> But I thought somehow sent this same fix a while back... >> >> Yes, I reported it and sent a patch for it that you acked... >> I guess my patch was never picked up. >> > > ... Better someone pick this up. > This build error is still occurring in linux-next (20130627). I first reported it and posted a patch for it on May-15 2013. Please merge either patch... Is anybody out there? > >>> >>> Ben. >>> >>>> --- >>>> drivers/platform/x86/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig >>>> index 8577261..37645b9 100644 >>>> --- a/drivers/platform/x86/Kconfig >>>> +++ b/drivers/platform/x86/Kconfig >>>> @@ -176,6 +176,7 @@ config FUJITSU_TABLET >>>> config AMILO_RFKILL >>>> tristate "Fujitsu-Siemens Amilo rfkill support" >>>> depends on RFKILL >>>> + depends on SERIO_I8042 >>>> ---help--- >>>> This is a driver for enabling wifi on some Fujitsu-Siemens Amilo >>>> laptops. >>> >> >> >> -- >> ~Randy > -- -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/