Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753387Ab3F0RKc (ORCPT ); Thu, 27 Jun 2013 13:10:32 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:36870 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227Ab3F0RK3 (ORCPT ); Thu, 27 Jun 2013 13:10:29 -0400 MIME-Version: 1.0 In-Reply-To: <87vc4zlczt.fsf@octavius.laptop.org> References: <1370580406-10254-1-git-send-email-dianders@chromium.org> <1370626110-1731-1-git-send-email-dianders@chromium.org> <87vc4zlczt.fsf@octavius.laptop.org> Date: Thu, 27 Jun 2013 10:10:26 -0700 X-Google-Sender-Auth: UxcfJcbwMdCC2eRDEHTtlsZ78dU Message-ID: Subject: Re: [PATCH v2 1/2] mmc: dw_mmc: Handle late vmmc regulators with EPROBE_DEFER From: Doug Anderson To: Chris Ball Cc: Olof Johansson , Andrew Bresticker , Alim Akhtar , Abhilash Kesavan , Tomasz Figa , Jaehoon Chung , Seungwon Jeon , Grant Likely , Rob Herring , Rob Landley , Will Newton , "devicetree-discuss@lists.ozlabs.org" , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 30 Chris, On Thu, Jun 27, 2013 at 9:44 AM, Chris Ball wrote: > This hunk breaks the build for me, because err_setup_bus and ret are > used in the error path of the call to mmc_add_host() in this function. > > I'll push a version that leaves those in. Let me know if you think > something strange is happening that made this work okay for you, like > a mismerge. WTF. OK, this is clearly my fault. I went back to the exact patch and it didn't compile for me, either. :( My typical workflow is to develop something in our local tree and then cherry-pick (and test!) on ToT linux. Probably what happened in this case was that there was a compile error and I didn't notice and somehow ended up testing my local tree (which doesn't error-check mmc_add_host). Sorry for the hassle. Leaving the err_setup_bus in is correct (and leaving the "ret" variable declared). I did those fixups and it now compiles and things boot. I haven't tested the deferral case in ToT yet, though. I'll try that now and post if something weird comes up. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/