Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817Ab3F0RSW (ORCPT ); Thu, 27 Jun 2013 13:18:22 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:52648 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353Ab3F0RSU (ORCPT ); Thu, 27 Jun 2013 13:18:20 -0400 MIME-Version: 1.0 In-Reply-To: <20130627162739.GY9294@intel.com> References: <1372177330-28013-1-git-send-email-mika.westerberg@linux.intel.com> <1372177330-28013-7-git-send-email-mika.westerberg@linux.intel.com> <20130627135405.GW9294@intel.com> <20130627162739.GY9294@intel.com> Date: Thu, 27 Jun 2013 10:18:19 -0700 X-Google-Sender-Auth: 4xqlpW0BZmJ7E8ZlGRTbfXLUtrc Message-ID: Subject: Re: [PATCH 6/6] x86/PCI: quirk Thunderbolt PCI-to-PCI bridges From: Yinghai Lu To: Mika Westerberg Cc: Bjorn Helgaas , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jesse Barnes , "Ronciak, John" , "Penner, Miles J" , Bruce Allan , "Kirill A. Shutemov" , Heikki Krogerus , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , "x86@kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 43 On Thu, Jun 27, 2013 at 9:27 AM, Mika Westerberg wrote: > On Thu, Jun 27, 2013 at 04:54:05PM +0300, Mika Westerberg wrote: >> I think that we can get this working so that we add a new flag to struct >> pci_dev, something like 'no_additional_hotplug_bus_space' and in this quirk >> set that. >> >> Then in __pci_bus_size_bridges() we do: >> >> pci_bridge_check_ranges(bus); >> if (bus->self->is_hotplug_bridge && >> !bus->self->no_additional_hotplug_bus_space) { >> additional_io_size = pci_hotplug_io_size; >> additional_mem_size = pci_hotplug_mem_size; >> } >> >> This should prevent the problem this patch was trying to solve. Does that >> work for you? > > Forget about that -- It looks like these messages are harmless: > > pcieport 0000:0a:05.0: BAR 8: can't assign mem (size 0x200000) > pcieport 0000:0a:05.0: BAR 9: can't assign mem pref (size 0x200000) > > It just means that we tried to allocate the resource but failed because the > bridge has that window closed, if I got it right. If user doesn't want to > see those, he/she can always pass 'pci=hpmensize=0,hpiosize=0' in the > kernel command line. Yes, that extra range for hotplug is optional, so if must+optional fails, second try will be must only. > > With pcibios_resource_survey_bus() fix, looks like this quirk is not needed > at all. Good. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/