Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754219Ab3F0VvY (ORCPT ); Thu, 27 Jun 2013 17:51:24 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:37110 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753886Ab3F0VvX (ORCPT ); Thu, 27 Jun 2013 17:51:23 -0400 Date: Thu, 27 Jun 2013 14:51:16 -0700 From: Stephen Hemminger To: Cong Wang Cc: netdev@vger.kernel.org, Daniel Borkmann , "David S. Miller" , Neil Horman , Jiri Pirko , Eric Dumazet , linux-kernel@vger.kernel.org Subject: Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton() Message-ID: <20130627145116.03e2f892@nehalam.linuxnetplumber.net> In-Reply-To: <1372315398-19683-3-git-send-email-amwang@redhat.com> References: <1372315398-19683-1-git-send-email-amwang@redhat.com> <1372315398-19683-3-git-send-email-amwang@redhat.com> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 41 On Thu, 27 Jun 2013 14:43:15 +0800 Cong Wang wrote: > Signed-off-by: Cong Wang > --- > include/net/inet_addr.h | 20 ++++++++++++++++++++ > net/core/netpoll.c | 24 ++---------------------- > 2 files changed, 22 insertions(+), 22 deletions(-) > > diff --git a/include/net/inet_addr.h b/include/net/inet_addr.h > index 66a16fe..1379287 100644 > --- a/include/net/inet_addr.h > +++ b/include/net/inet_addr.h > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > #include > > union inet_addr { > @@ -59,4 +60,23 @@ static inline bool inet_addr_multicast(const union inet_addr *ipa) > } > #endif > > +static inline int inet_pton(const char *str, union inet_addr *addr) > +{ > A couple of comments: 1. No reason for this to be inline 2. If function has same name as userspace it must have same arguments and return value. Either: a. rename it to kinet_pton or some other name b. make it work the same. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/