Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754183Ab3F0XZq (ORCPT ); Thu, 27 Jun 2013 19:25:46 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:36398 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753707Ab3F0XZp (ORCPT ); Thu, 27 Jun 2013 19:25:45 -0400 MIME-Version: 1.0 In-Reply-To: <20130627152800.494a6043607a62feb35e9739@linux-foundation.org> References: <20130619210918.DF616222D8@clements> <20130626162107.9237360f7646ec25f23cf5aa@linux-foundation.org> <20130627152800.494a6043607a62feb35e9739@linux-foundation.org> Date: Thu, 27 Jun 2013 19:25:44 -0400 Message-ID: Subject: Re: [PATCH] nbd: correct disconnect behavior From: Paul Clements To: Andrew Morton Cc: kernel list , "nbd-general@lists.sourceforge.net" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 30 On Thu, Jun 27, 2013 at 6:28 PM, Andrew Morton wrote: > On Thu, 27 Jun 2013 18:20:37 -0400 Paul Clements wrote: > OK, but. "Would it be safer to clear ->disconnect in NBD_DO_IT?" About the same in terms of safety. Both ioctls have to be called to set up the device and neither can be called again, until the device is reset. > If not safer, would it be cleaner? I don't know, seems like a toss up. NBD_SET_SOCK is the earliest place that the socket might conceivably be usable, so I wanted to clear disconnect there (e.g., in case an alternate/new version of NBD_DO_IT, as has been discussed, is ever implemented). >> > The cool kids are using bool lately ;) >> > >> >> Hey, maybe I want to be able to compile with gcc 2.7.2 ? :) > > Sob, I miss 2.7.2. It was a good 50% faster than the new improved > models. But I don't think this yearning makes us cool. No, I think it just makes us old :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/