Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755485Ab3F1QWf (ORCPT ); Fri, 28 Jun 2013 12:22:35 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:63368 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753912Ab3F1QWd (ORCPT ); Fri, 28 Jun 2013 12:22:33 -0400 MIME-Version: 1.0 In-Reply-To: <20130628093319.D4DE6E0090@blue.fi.intel.com> References: <1372177330-28013-1-git-send-email-mika.westerberg@linux.intel.com> <1372177330-28013-5-git-send-email-mika.westerberg@linux.intel.com> <20130628093319.D4DE6E0090@blue.fi.intel.com> Date: Fri, 28 Jun 2013 09:22:32 -0700 X-Google-Sender-Auth: sdZQF8vzgWg5hSdPw1zASMaOXFA Message-ID: Subject: Re: [PATCH 4/6] PCI: acpiphp: check for new devices on enabled host From: Yinghai Lu To: "Kirill A. Shutemov" Cc: Mika Westerberg , Greg Kroah-Hartman , Bjorn Helgaas , "Rafael J. Wysocki" , Jesse Barnes , John Ronciak , Miles J Penner , Bruce Allan , Heikki Krogerus , Linux Kernel Mailing List , "linux-pci@vger.kernel.org" , "the arch/x86 maintainers" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1796 Lines: 46 On Fri, Jun 28, 2013 at 2:33 AM, Kirill A. Shutemov wrote: > Yinghai Lu wrote: >> On Tue, Jun 25, 2013 at 9:22 AM, Mika Westerberg >> wrote: >> > From: "Kirill A. Shutemov" >> > >> > Current acpiphp_check_bridge() implementation is pretty dumb: >> > - it enables the slot if it's not enabled and the slot status is >> > ACPI_STA_ALL; >> > - it disables the slot if it's enabled and slot is not in ACPI_STA_ALL >> > state. >> > >> > This behavior is not enough to handle Thunderbolt chaining case >> > properly. We need to actually rescan for new devices even if a device >> > has already in the slot. >> > >> > The new implementation disables and stops the slot if it's not in >> > ACPI_STA_ALL state. >> > >> > For ACPI_STA_ALL state we first trim devices which don't respond and >> > look for the ones after that. We do that even if slot already enabled >> > (SLOT_ENABLED). >> >> that is not right, some time BUS_CHECK is even sent root bus. >> in that case, stop all devices in slots and load driver again. >> >> like you put one card in one slots, but all devices in other slots get stop >> and enable again. > > We don't stop enabled devices, we only stop and remove devices which don't > respond. See patch 3/6. > > I don't see how it's harmful. Do you? then please check with disable_device to put back pci_dev ref, also may need to trim corresponding acpi devices. so this patch is helping: multiple plug-in and remove? Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/