Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768Ab3F1Uox (ORCPT ); Fri, 28 Jun 2013 16:44:53 -0400 Received: from mail-vb0-f53.google.com ([209.85.212.53]:49868 "EHLO mail-vb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017Ab3F1Uow (ORCPT ); Fri, 28 Jun 2013 16:44:52 -0400 MIME-Version: 1.0 In-Reply-To: <1372450451-8790-3-git-send-email-lszubowi@redhat.com> References: <1372450451-8790-1-git-send-email-lszubowi@redhat.com> <1372450451-8790-3-git-send-email-lszubowi@redhat.com> Date: Fri, 28 Jun 2013 13:44:51 -0700 Message-ID: Subject: Re: [PATCH 2/3] acpi: Eliminate console msg if pstore.backend excludes ERST From: Tony Luck To: Lenny Szubowicz Cc: Anton Vorontsov , Matt Fleming , Linux Kernel Mailing List , n.hamaguchi@jp.fujitsu.com, Don Zickus Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 24 On Fri, Jun 28, 2013 at 1:14 PM, Lenny Szubowicz wrote: > - if (pstore_register(&erst_info)) { > - pr_info(ERST_PFX "Could not register with persistent store\n"); > + rc = pstore_register(&erst_info); > + if (rc) { > + if (rc != -EPERM) > + pr_info(ERST_PFX > + "Could not register with persistent store\n"); > + erst_info.buf = NULL; > + erst_info.bufsize = 0; Mismatch between part 1 and part 2 here ... we return -EINVAL if our name doesn't match the desired backend ... but you only suppress the "Could not register" message for -EPERM Or am I confused while just looking at patch fragments? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/