Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363Ab3F2BrV (ORCPT ); Fri, 28 Jun 2013 21:47:21 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:60439 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752802Ab3F2BrU (ORCPT ); Fri, 28 Jun 2013 21:47:20 -0400 Date: Fri, 28 Jun 2013 18:42:53 -0700 From: Anton Vorontsov To: Wei Yongjun Cc: dwmw2@infradead.org, khilman@linaro.org, andrii.tseglytskyi@ti.com, nm@ti.com, jean.pihet@newoldbits.com, tony@atomide.com, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] PM / AVS: SmartReflex: remove redundant dev_err call in omap_sr_probe() Message-ID: <20130629014252.GC20924@lizard> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1432 Lines: 40 On Wed, Jun 26, 2013 at 09:57:14AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun > --- The patch does not apply to the battery-2.6.git tree... :-/ (In the patch I see "sr_info", but in the current driver there is just "sr".) > drivers/power/avs/smartreflex.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c > index db9973b..c26acfc 100644 > --- a/drivers/power/avs/smartreflex.c > +++ b/drivers/power/avs/smartreflex.c > @@ -871,10 +871,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) > > mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > sr_info->base = devm_ioremap_resource(&pdev->dev, mem); > - if (IS_ERR(sr_info->base)) { > - dev_err(&pdev->dev, "%s: ioremap fail\n", __func__); > + if (IS_ERR(sr_info->base)) > return PTR_ERR(sr_info->base); > - } > > irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/