Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498Ab3F3Hqc (ORCPT ); Sun, 30 Jun 2013 03:46:32 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:59163 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827Ab3F3Hqb (ORCPT ); Sun, 30 Jun 2013 03:46:31 -0400 Message-ID: <51CFE255.6050003@hitachi.com> Date: Sun, 30 Jun 2013 16:46:29 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Oleg Nesterov Cc: Steven Rostedt , Frederic Weisbecker , "zhangwei(Jovi)" , Ingo Molnar , Srikar Dronamraju , lkml Subject: Re: Re: [PATCH] tracing/kprobe: Recover old array if fails to enable kprobe References: <51CD25A6.2030907@hitachi.com> <20130628130452.1132.85665.stgit@mhiramat-M0-7522> <20130628142744.GA19278@redhat.com> <1372430586.18733.332.camel@gandalf.local.home> <20130628184325.GA21822@redhat.com> In-Reply-To: <20130628184325.GA21822@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1342 Lines: 40 (2013/06/29 3:43), Oleg Nesterov wrote: > On 06/28, Steven Rostedt wrote: >> >> On Fri, 2013-06-28 at 16:27 +0200, Oleg Nesterov wrote: >>> >>> Ah, but this conflicts with the other changes I sent. They have >>> your acks, and iiuc Steven is going to apply them. >> >> I'll see if I can solve any conflicts. I need to get my -rt versions out >> and start on the new 3.6 stable today. Then after that, I plan on going >> though and getting all the tracing patches settled. > > Thanks! > >>> Besides, this fix is not complete afaics, we should also clear >>> TP_FLAG_TRACE/PROFILE if __enable_trace_probe() fails. > > Yes. > > And I forgot to mention, until we fix the races we discuss in another > thread, this WARN_ON() doesn't look right. So perhaps it would be > really better to delay this change a bit. Agreed, this fix is not a critical one. The racing problem of dynamic events is what we have to solve at first. Thank you! -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/