Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752765Ab3GAHFo (ORCPT ); Mon, 1 Jul 2013 03:05:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28285 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008Ab3GAHFn (ORCPT ); Mon, 1 Jul 2013 03:05:43 -0400 Message-ID: <1372662315.2974.20.camel@cr0> Subject: Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton() From: Cong Wang To: Stephen Hemminger Cc: netdev@vger.kernel.org, Daniel Borkmann , "David S. Miller" , Neil Horman , Jiri Pirko , Eric Dumazet , linux-kernel@vger.kernel.org Date: Mon, 01 Jul 2013 15:05:15 +0800 In-Reply-To: <20130627145116.03e2f892@nehalam.linuxnetplumber.net> References: <1372315398-19683-1-git-send-email-amwang@redhat.com> <1372315398-19683-3-git-send-email-amwang@redhat.com> <20130627145116.03e2f892@nehalam.linuxnetplumber.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 28 On Thu, 2013-06-27 at 14:51 -0700, Stephen Hemminger wrote: > > > > +static inline int inet_pton(const char *str, union inet_addr *addr) > > +{ > > > > A couple of comments: > 1. No reason for this to be inline Okay, I will move them into net/core/utils.c. > 2. If function has same name as userspace it must have same arguments > and return value. Either: > a. rename it to kinet_pton or some other name > b. make it work the same. > Makes sense too me, I will try your option b) first, if it is over-kill I will fall back to option a). Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/