Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868Ab3GAHPe (ORCPT ); Mon, 1 Jul 2013 03:15:34 -0400 Received: from mail-ea0-f175.google.com ([209.85.215.175]:55691 "EHLO mail-ea0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506Ab3GAHPd (ORCPT ); Mon, 1 Jul 2013 03:15:33 -0400 From: stefan.seyfried@googlemail.com To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Stefan Seyfried Subject: [PATCH] 8250_pci: improve code comments and Kconfig help Date: Mon, 1 Jul 2013 09:14:21 +0200 Message-Id: <1372662861-11231-2-git-send-email-stefan.seyfried@googlemail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1372662861-11231-1-git-send-email-stefan.seyfried@googlemail.com> References: <20130630160226.GA26644@kroah.com> <1372662861-11231-1-git-send-email-stefan.seyfried@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1798 Lines: 49 From: Stefan Seyfried The recent regression about NetMos 9835 Multi-I/O boards indicates that comment pointing to the parport_serial driver could be helpful. Signed-off-by: Stefan Seyfried --- drivers/tty/serial/8250/8250_pci.c | 6 ++++++ drivers/tty/serial/8250/Kconfig | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index c52948b..c626c4f 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c @@ -4797,6 +4797,12 @@ static struct pci_device_id serial_pci_tbl[] = { PCI_VENDOR_ID_IBM, 0x0299, 0, 0, pbn_b0_bt_2_115200 }, + /* + * other NetMos 9835 devices are most likely handled by the + * parport_serial driver, check drivers/parport/parport_serial.c + * before adding them here. + */ + { PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9901, 0xA000, 0x1000, 0, 0, pbn_b0_1_115200 }, diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index a1ba94d..f3b306e 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -116,6 +116,8 @@ config SERIAL_8250_PCI This builds standard PCI serial support. You may be able to disable this feature if you only need legacy serial support. Saves about 9K. + Note that serial ports on NetMos 9835 Multi-I/O cards are handled + by the parport_serial driver, enabled with CONFIG_PARPORT_SERIAL. config SERIAL_8250_HP300 tristate -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/