Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754204Ab3GAOHs (ORCPT ); Mon, 1 Jul 2013 10:07:48 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:50947 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751916Ab3GAOHr (ORCPT ); Mon, 1 Jul 2013 10:07:47 -0400 MIME-Version: 1.0 In-Reply-To: <1372682002-15373-3-git-send-email-leiwen@marvell.com> References: <1372662634-12833-1-git-send-email-leiwen@marvell.com> <1372682002-15373-1-git-send-email-leiwen@marvell.com> <1372682002-15373-3-git-send-email-leiwen@marvell.com> From: Paul Turner Date: Mon, 1 Jul 2013 07:07:15 -0700 Message-ID: Subject: Re: [V2 2/2] sched: update cfs_rq weight earlier in enqueue_entity To: Lei Wen Cc: Alex Shi , Peter Zijlstra , Ingo Molnar , Ingo Molnar , Kamalesh Babulal , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1748 Lines: 52 Could you please restate the below? On Mon, Jul 1, 2013 at 5:33 AM, Lei Wen wrote: > Since we are going to calculate cfs_rq's average ratio by > runnable_load_avg/load.weight I don't understand what you mean by this. >, if not increase the load.weight prior to > enqueue_entity_load_avg, it may lead to one cfs_rq's avg ratio higher > than 100%. > Or this. > Adjust the sequence, so that all ratio is kept below 100%. > > Signed-off-by: Lei Wen > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 07bd74c..d1eee84 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -1788,8 +1788,8 @@ enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) > * Update run-time statistics of the 'current'. > */ > update_curr(cfs_rq); > - enqueue_entity_load_avg(cfs_rq, se, flags & ENQUEUE_WAKEUP); > account_entity_enqueue(cfs_rq, se); > + enqueue_entity_load_avg(cfs_rq, se, flags & ENQUEUE_WAKEUP); account_entity_enqueue is independent of enqueue_entity_load_avg; their order should not matter. Further, should we restore the reverted amortization commit (improves context switch times) enqueue_entity_load_avg needs to precede account_entity_enqueue as it may update se->load.weight. > update_cfs_shares(cfs_rq); > > if (flags & ENQUEUE_WAKEUP) { > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/