Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754329Ab3GAOZn (ORCPT ); Mon, 1 Jul 2013 10:25:43 -0400 Received: from mail-oa0-f44.google.com ([209.85.219.44]:46442 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754106Ab3GAOZl convert rfc822-to-8bit (ORCPT ); Mon, 1 Jul 2013 10:25:41 -0400 MIME-Version: 1.0 In-Reply-To: <4129319.59EevnP3PH@vostro.rjw.lan> References: <1372362463-4186-1-git-send-email-naresh.bhat@linaro.org> <4129319.59EevnP3PH@vostro.rjw.lan> Date: Mon, 1 Jul 2013 19:55:40 +0530 Message-ID: Subject: Re: [PATCH] ACPI/fan: Initialize acpi_state variable From: Naresh Bhat To: "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, len.brown@intel.com, Patch Tracking , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1632 Lines: 51 Opps sorry about that. I have added my sign-off and send the patch. Thanks Naresh Bhat On 1 July 2013 19:29, Rafael J. Wysocki wrote: > On Monday, July 01, 2013 05:31:46 PM Naresh Bhat wrote: >> Hi Rafeal, >> >> I appreciate if you give any feedback on the provided patch. > > The patch is OK, but please add your sign-off. > > Thanks, > Rafael > > >> On 28 June 2013 01:17, wrote: >> > From: Naresh Bhat >> > >> > CC drivers/acpi/fan.o >> > drivers/acpi/fan.c: In function ?fan_get_cur_state?: >> > drivers/acpi/fan.c:96:9: warning: ?acpi_state? may be used uninitialized in this function [-Wuninitialized] >> > --- >> > drivers/acpi/fan.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c >> > index f815da8..f961435 100644 >> > --- a/drivers/acpi/fan.c >> > +++ b/drivers/acpi/fan.c >> > @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long >> > { >> > struct acpi_device *device = cdev->devdata; >> > int result; >> > - int acpi_state; >> > + int acpi_state = ACPI_STATE_D0; >> > >> > if (!device) >> > return -EINVAL; >> > -- >> > 1.7.9.5 >> > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/