Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 7 Oct 2002 09:51:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 7 Oct 2002 09:51:35 -0400 Received: from dell-paw-3.cambridge.redhat.com ([195.224.55.237]:54780 "EHLO executor.cambridge.redhat.com") by vger.kernel.org with ESMTP id ; Mon, 7 Oct 2002 09:51:35 -0400 From: David Howells To: torvalds@transmeta.com Cc: linux-kernel@vger.kernel.org Subject: bcopy() User-Agent: EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2 (i686-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Date: Mon, 07 Oct 2002 14:57:12 +0100 Message-ID: <12660.1033999032@warthog.cambridge.redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 640 Lines: 17 Hi Linus, The implementation of bcopy() in lib/string.c (and some other places such as the XFS header files) is incorrect as it implements bcopy as memcpy. This is wrong: bcopy should be the equivalent of memmove (which handles overlapping areas correctly). I've dicussed it with a number of people, and the general consensus seems to be that it should be nuked entirely? Do you agree? David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/