Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755291Ab3GAUAM (ORCPT ); Mon, 1 Jul 2013 16:00:12 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:36268 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755262Ab3GAUAI (ORCPT ); Mon, 1 Jul 2013 16:00:08 -0400 Message-ID: <51D1DFC2.4080209@cogentembedded.com> Date: Tue, 02 Jul 2013 00:00:02 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Pavel Machek CC: Tony Lindgren , linux-omap@vger.kernel.org, pali.rohar@gmail.com, kernel list , linux-arm-kernel , Aaro Koskinen Subject: Re: [PATCH] N900: fix operation on emulator References: <20130613142809.GA3775@amd.pavel.ucw.cz> <20130613145724.GH8164@atomide.com> <20130613155240.GB3775@amd.pavel.ucw.cz> <20130613161418.GJ8164@atomide.com> <20130613230808.GA14876@amd.pavel.ucw.cz> <20130614055629.GM8164@atomide.com> <20130614212816.GA31768@atrey.karlin.mff.cuni.cz> <20130617111031.GQ20992@atomide.com> <20130701140315.GA15318@amd.pavel.ucw.cz> <51D1C8DD.6040409@cogentembedded.com> <20130701195147.GA22174@amd.pavel.ucw.cz> In-Reply-To: <20130701195147.GA22174@amd.pavel.ucw.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1673 Lines: 58 Hello. On 07/01/2013 11:51 PM, Pavel Machek wrote: >>> Errata workarounds for N900 hardware actually break operation on >>> emulator. Fix it. >>> This approach was suggested by Pali Roh?r >>> (thanks!). >>> (Also explain what "sleep_ind" led actually does). >> Looks like unrelated change and probably worth another patch? > Separate patch for adding single-line comment? If it's unrelated to the main patch purpose, yes. As the Russians say: "cutlets separately and flies separately". >>> --- a/arch/arm/mach-omap2/board-rx51.c >>> +++ b/arch/arm/mach-omap2/board-rx51.c >>> @@ -33,9 +33,12 @@ >>> #include "pm.h" >>> #include "sdram-nokia.h" >>> #include "board-rx51-secure.h" >>> +#include "soc.h" >>> >>> #define RX51_GPIO_SLEEP_IND 162 >>> >>> +/* This lights up left part of keyboard */ >>> + >>> static struct gpio_led gpio_leds[] = { > ... >>> #ifdef CONFIG_ARM_ERRATA_430973 >>> - printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n"); >>> - /* set IBE to 1 */ >>> - rx51_secure_update_aux_cr(1 << 6, 0); >>> + if (omap_type() == OMAP2_DEVICE_TYPE_SEC) { >>> + printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n"); >> How about pr_info() instead? > Would not that be unrelated change and worth of separate > patch? No, this would be a related change. Sarcasm wasted. > :-). > Pavel WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/