Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755515Ab3GAV7j (ORCPT ); Mon, 1 Jul 2013 17:59:39 -0400 Received: from cynthia.allandria.com ([76.245.85.235]:33014 "EHLO cynthia.pants.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754873Ab3GAV7i (ORCPT ); Mon, 1 Jul 2013 17:59:38 -0400 Date: Mon, 1 Jul 2013 14:59:32 -0700 From: Brad Boyer To: Finn Thain Cc: Geert Uytterhoeven , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] m68k/mac: Allocate IOP message pool and queues dynamically Message-ID: <20130701215932.GA12663@cynthia.pants.nu> References: <1372586542-1318-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1308 Lines: 36 On Mon, Jul 01, 2013 at 05:46:48PM +1000, Finn Thain wrote: > > On Sun, 30 Jun 2013, Geert Uytterhoeven wrote: > > > - > > -/* > > - * Register the interrupt handler for the IOPs. > > - * TODO: might be wrong for non-OSS machines. Anyone? > > - */ > > - > > -void __init iop_register_interrupts(void) > > -{ > > - if (iop_ism_present) { > > + /* > > + * Register the interrupt handler for the IOPs. > > + * TODO: might be wrong for non-OSS machines. Anyone? > > My testing with a non-OSS machine (Quadra 950) indicates that the TODO is > obsolete. And the comment "register the interrupt handler for the IOPs" is > a bit silly. It merely re-phrases the code. Otherwise, this patch looks > good to me. Thanks. The code was all originally written and tested only on the IIfx. That's all JMT had, and at the time it was all I had as well. I have since acquired a Quadra 950. Lots of these comments are just out of date. I know it got tested on either a Quadra 900 or Quadra 950 after that comment was put in the source. Brad Boyer flar@allandria.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/