Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932108Ab3GBDB5 (ORCPT ); Mon, 1 Jul 2013 23:01:57 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:8873 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932097Ab3GBDBw (ORCPT ); Mon, 1 Jul 2013 23:01:52 -0400 Message-ID: <51D24299.9050209@atmel.com> Date: Tue, 2 Jul 2013 11:01:45 +0800 From: Bo Shen User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Richard Genoud CC: , Nicolas Ferre , , , =?ISO-8859-1?Q?Uwe_Kleine-K=F6nig?= Subject: Re: [RFC PATCH 01/13] misc: atmel_ssc: add device tree DMA support References: <1372667978-4718-1-git-send-email-richard.genoud@gmail.com> <1372667978-4718-2-git-send-email-richard.genoud@gmail.com> In-Reply-To: <1372667978-4718-2-git-send-email-richard.genoud@gmail.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 27 Hi Richard, On 7/1/2013 16:39, Richard Genoud wrote: > The ssc device has to fill the at_dma_slave structure with the > device tree informations. > Doing a of_dma_request_slave_channel()+dma_release_channel() for that > seems wrong (or at least not very clean). Please hold on of this, as to the ASoC dmaengine will deal with this. So, we not need do it manually. Now, I am working on it. And will send out the patch soon after testing OK. > Signed-off-by: Richard Genoud > --- > drivers/misc/atmel-ssc.c | 56 +++++++++++++++++++++++++++++++ > include/linux/atmel-ssc.h | 2 ++ > include/linux/platform_data/dma-atmel.h | 2 ++ > 3 files changed, 60 insertions(+) Best Regards, Bo Shen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/