Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932210Ab3GBGFS (ORCPT ); Tue, 2 Jul 2013 02:05:18 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:47987 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887Ab3GBGFQ (ORCPT ); Tue, 2 Jul 2013 02:05:16 -0400 From: "Hebbar, Gururaja" To: "Nori, Sekhar" CC: "khilman@linaro.org" , "tony@atomide.com" , "Cousson, Benoit" , "linux-omap@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "Bedia, Vaibhav" , "Rajashekhara, Sudhakar" , "Grant Likely" , Rob Herring , "Rob Landley" , Alessandro Zummo , "rtc-linux@googlegroups.com" , "linux-doc@vger.kernel.org" Subject: RE: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events Thread-Topic: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events Thread-Index: AQHOc+J3RdUEBUL1FkS6xaDIitR2t5lQZZwAgACGXFA= Date: Tue, 2 Jul 2013 06:04:22 +0000 Message-ID: <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> <51D26CFA.5090500@ti.com> In-Reply-To: <51D26CFA.5090500@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r6265bM7005835 Content-Length: 2432 Lines: 83 On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote: > On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: > > On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN) > > is available to enable Alarm Wakeup feature. This register needs to be > > properly handled for the rtcwake to work properly. > > > > Platforms using such IP should set "ti,am3352-rtc" in rtc device dt > > compatibility node. > > > > Signed-off-by: Hebbar Gururaja > > Cc: Grant Likely > > Cc: Rob Herring > > Cc: Rob Landley > > Cc: Sekhar Nori > > Cc: Kevin Hilman > > Cc: Alessandro Zummo > > Cc: rtc-linux@googlegroups.com > > Cc: devicetree-discuss@lists.ozlabs.org > > Cc: linux-doc@vger.kernel.org > > --- > > [...] > > > -#define OMAP_RTC_DATA_DA830_IDX 1 > > +#define OMAP_RTC_DATA_DA830_IDX 1 > > +#define OMAP_RTC_DATA_AM335X_IDX 2 > > > > static struct platform_device_id omap_rtc_devtype[] = { > > { > > @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = { > > }, { > > .name = "da830-rtc", > > .driver_data = OMAP_RTC_HAS_KICKER, > > + }, { > > + .name = "am335x-rtc", > > may be use am3352-rtc here just to keep the platform device name and of > compatible in sync. Correct. I will update the same in v2. > > > + .driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN, > > }, > > {}, > > It is better to use the index defined above in the static initialization > so they remain in sync. Sorry. I didn’t get this. > > ... > [OMAP_RTC_DATA_DA830_IDX] = { > .name = "da830-rtc", > .driver_data = OMAP_RTC_HAS_KICKER, > }, > ... > > > }; > > @@ -318,6 +333,9 @@ static const struct of_device_id omap_rtc_of_match[] = { > > { .compatible = "ti,da830-rtc", > > .data = &omap_rtc_devtype[OMAP_RTC_DATA_DA830_IDX], > > }, > > + { .compatible = "ti,am3352-rtc", > > + .data = &omap_rtc_devtype[OMAP_RTC_DATA_AM335X_IDX], > > + }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, omap_rtc_of_match); > > Apart from these minor issues, the patch looks good to me. > > Acked-by: Sekhar Nori > > Thanks, > Sekhar > Regards, Gururaja ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?