Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180Ab3GBGKe (ORCPT ); Tue, 2 Jul 2013 02:10:34 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:44150 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120Ab3GBGKc (ORCPT ); Tue, 2 Jul 2013 02:10:32 -0400 Message-ID: <51D26E98.9040303@ti.com> Date: Tue, 2 Jul 2013 11:39:28 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Hebbar, Gururaja" CC: "khilman@linaro.org" , "tony@atomide.com" , "Cousson, Benoit" , "linux-omap@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "davinci-linux-open-source@linux.davincidsp.com" , "Bedia, Vaibhav" , "Rajashekhara, Sudhakar" , Grant Likely , Rob Herring , Rob Landley , Alessandro Zummo , "rtc-linux@googlegroups.com" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH 3/4] rtc: omap: add rtc wakeup support to alarm events References: <1372412109-986-1-git-send-email-gururaja.hebbar@ti.com> <1372412109-986-4-git-send-email-gururaja.hebbar@ti.com> <51D26CFA.5090500@ti.com> <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> In-Reply-To: <1BAFE6F6C881BF42822005164F1491C33EC4E7AB@DBDE04.ent.ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2150 Lines: 69 On 7/2/2013 11:34 AM, Hebbar, Gururaja wrote: > On Tue, Jul 02, 2013 at 11:32:34, Nori, Sekhar wrote: >> On 6/28/2013 3:05 PM, Hebbar Gururaja wrote: >>> On some platforms (like AM33xx), a special register (RTC_IRQWAKEEN) >>> is available to enable Alarm Wakeup feature. This register needs to be >>> properly handled for the rtcwake to work properly. >>> >>> Platforms using such IP should set "ti,am3352-rtc" in rtc device dt >>> compatibility node. >>> >>> Signed-off-by: Hebbar Gururaja >>> Cc: Grant Likely >>> Cc: Rob Herring >>> Cc: Rob Landley >>> Cc: Sekhar Nori >>> Cc: Kevin Hilman >>> Cc: Alessandro Zummo >>> Cc: rtc-linux@googlegroups.com >>> Cc: devicetree-discuss@lists.ozlabs.org >>> Cc: linux-doc@vger.kernel.org >>> --- >> >> [...] >> >>> -#define OMAP_RTC_DATA_DA830_IDX 1 >>> +#define OMAP_RTC_DATA_DA830_IDX 1 >>> +#define OMAP_RTC_DATA_AM335X_IDX 2 >>> >>> static struct platform_device_id omap_rtc_devtype[] = { >>> { >>> @@ -309,6 +321,9 @@ static struct platform_device_id omap_rtc_devtype[] = { >>> }, { >>> .name = "da830-rtc", >>> .driver_data = OMAP_RTC_HAS_KICKER, >>> + }, { >>> + .name = "am335x-rtc", >> >> may be use am3352-rtc here just to keep the platform device name and of >> compatible in sync. > > Correct. I will update the same in v2. > >> >>> + .driver_data = OMAP_RTC_HAS_KICKER | OMAP_RTC_HAS_IRQWAKEEN, >>> }, >>> {}, >> >> It is better to use the index defined above in the static initialization >> so they remain in sync. > > Sorry. I didn’t get this. > See example below I provided. If its still not clear, let me know what is not clear. >> ... >> [OMAP_RTC_DATA_DA830_IDX] = { >> .name = "da830-rtc", >> .driver_data = OMAP_RTC_HAS_KICKER, >> }, Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/