Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756141Ab3GBKRp (ORCPT ); Tue, 2 Jul 2013 06:17:45 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:33731 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755245Ab3GBKRn (ORCPT ); Tue, 2 Jul 2013 06:17:43 -0400 Date: Tue, 2 Jul 2013 11:17:18 +0100 From: Mark Brown To: Felipe Balbi Cc: Sourav Poddar , spi-devel-general@lists.sourceforge.net, grant.likely@linaro.org, rnayak@ti.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20130702101718.GE27646@sirena.org.uk> References: <1372755399-21769-1-git-send-email-sourav.poddar@ti.com> <20130702093247.GY27646@sirena.org.uk> <20130702094404.GL3352@arwen.pp.htv.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l6uVvLg33S+39+i8" Content-Disposition: inline In-Reply-To: <20130702094404.GL3352@arwen.pp.htv.fi> X-Cookie: You will contract a rare disease. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 94.175.92.69 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCHv2] drivers: spi: Add qspi flash controller X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1858 Lines: 47 --l6uVvLg33S+39+i8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 02, 2013 at 12:44:04PM +0300, Felipe Balbi wrote: > On Tue, Jul 02, 2013 at 10:32:47AM +0100, Mark Brown wrote: > > Does this hardware really support anything other than 8 bits per word? > > There is no code in the driver which pays any attention to the word > > size... > the HW has a 128-bit shift register ;-) but driver doesn't look > complete. That's not the issue - remember that SPI specifies big endian byte ordering for words on the bus so things will need to be reordered by the hardware for anything except 8 bits. --l6uVvLg33S+39+i8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJR0qiqAAoJELSic+t+oim9YAsP/1np9MigYru6uKF4qNf7pVl9 UKaCIhPzQAAmC1V5eqfHyPkKCsX2a4SWA0W0KGFRUbGplW997utTsJGe0P3GzQ36 m/8RQtJTZV4LmsTJi/dPxJ3DvT9X5KZOUFF6KULUHHyG8UNGwHycKc/+oTOeZmFq AUlBbSOBPGm8g7zsZ9D4+0jvQtlyVc3c8SmIjQWYj9CnJru2l2RYlBrYrYQ24yT7 vpgIzoFtxhrAmEOxGzh/XYyfkaTCq/yIwNvbh47OlYKCYafYExPwCe3DH3NDNfyN 1wLx6xykQCU0lVG4/FF1/JhWwUdWt9R2zyVMj9eNZC8ZV7jM9iiUyhNrtEAGJ1wI NqexzOCvTlnFbtSRwRLC8pB0mcYldkNpq0v8HkI2gLDhXYWMEtgkUwNbJoXaJ7yL dHUSPk5YINWy6sqgli4m4I1w6iMRSjZLRf+3VZsuccpIIrITX768PzF9WhyF8rVd oqOeSD1R9F/pczYchvNtGlHlvSAdGjq/xsTydVA4f8aOlDFn7+/W7WrpKVPjJQZi eaYjB/Tp1CJiU1VeF5XMxLZkYUZmSJWoUNNNFs3TzOa+Qg4C1fqf/ygYTC5E9XaM JIhmSVfDoHogTPyKYjiwacsUrytsMoQGeFlGIyHDsHBlxYL/gu/ggxh/Qc6sN1V5 tNa4OodyOnAA9tUgabd9 =39MU -----END PGP SIGNATURE----- --l6uVvLg33S+39+i8-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/