Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243Ab3GBK5S (ORCPT ); Tue, 2 Jul 2013 06:57:18 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:35966 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834Ab3GBK5P (ORCPT ); Tue, 2 Jul 2013 06:57:15 -0400 MIME-Version: 1.0 In-Reply-To: <51D2888E.8020503@asianux.com> References: <51CA8AB8.7080504@asianux.com> <51CA900E.9020407@nod.at> <51CA9E92.4000107@asianux.com> <51CAA0C6.60007@nod.at> <51CAA78C.5040900@asianux.com> <51CAA8D6.9000505@nod.at> <51CAAD1D.8050801@asianux.com> <51CAAE7C.9090003@nod.at> <51CAB556.4070700@asianux.com> <51CAB689.70008@nod.at> <51CABBDD.403@asianux.com> <51CABFAC.1040505@nod.at> <51CAC0D0.60505@asianux.com> <51D0DE09.4090702@asianux.com> <51D0FAFE.5010500@asianux.com> <51D23766.8000605@asianux.com> <51D2888E.8020503@asianux.com> Date: Tue, 2 Jul 2013 12:57:15 +0200 X-Google-Sender-Auth: jc6U-20PFZDPt9kzlomF31GfNbo Message-ID: Subject: Re: [PATCH] include/asm-generic/io.h: add dummy fuctions to support 'COMPILE_TEST' in 'asm-generic'. From: Geert Uytterhoeven To: Chen Gang Cc: Richard Weinberger , Arnd Bergmann , Jeff Dike , David Sharp , "sfr@canb.auug.org.au" , Steven Rostedt , Ingo Molnar , uml-devel , uml-user , "linux-kernel@vger.kernel.org" , Linux-Arch , Mark Brown , David Miller , Andrew Morton , Jiri Kosina Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1838 Lines: 44 On Tue, Jul 2, 2013 at 10:00 AM, Chen Gang wrote: > On 07/02/2013 03:19 PM, Geert Uytterhoeven wrote: >> On Tue, Jul 2, 2013 at 4:13 AM, Chen Gang wrote: >>> > 'asm-generic' need provide necessary configuration checking, if can't >>> > pass checking, 'asm-generic' shouldn't implement it. >>> > >>> > For 'COMPILE_TEST', according to its help contents, 'asm-generic' need >>> > let it pass configuration checking, and provide related dummy contents >>> > for it. >>> > >>> > Part of 'COMPLE_TEST' help contents in "init/Kconfig": >>> > >>> > "...Despite they cannot be loaded there (or even when they load they cannot be used due to missing HW support)..." >>> > >>> > >>> > Signed-off-by: Chen Gang >> NAKed-by: Geert Uytterhoeven >> >> Please don't clutter the code with checks for CONFIG_COMPILE_TEST. > > Do you mean: 'asm-generic' should not support 'COMPILE_TEST' (the > platform should not support 'COMPILE_TEST") ? > > Or you mean: 'COMPILE_TEST' should not exist in kernel ? I mean that COMPILE_TEST should exist in Kconfig files only. It's only meant to have more compile coverage, not to "fix" (through #ifdef) more code to make it compile. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/