Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753482Ab3GBPbH (ORCPT ); Tue, 2 Jul 2013 11:31:07 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:63000 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907Ab3GBPbE (ORCPT ); Tue, 2 Jul 2013 11:31:04 -0400 Message-ID: <51D2F306.7040603@metafoo.de> Date: Tue, 02 Jul 2013 17:34:30 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Bo Shen CC: Mark Brown , alsa-devel@alsa-project.org, richard.genoud@gmail.com, Nicolas Ferre , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework References: <1372755849-19546-1-git-send-email-voice.shen@atmel.com> <1372755849-19546-3-git-send-email-voice.shen@atmel.com> In-Reply-To: <1372755849-19546-3-git-send-email-voice.shen@atmel.com> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 54 On 07/02/2013 11:04 AM, Bo Shen wrote: [...] > -/*--------------------------------------------------------------------------*\ > - * DMAENGINE operations > -\*--------------------------------------------------------------------------*/ > -static bool filter(struct dma_chan *chan, void *slave) > -{ > - struct at_dma_slave *sl = slave; > - > - if (sl->dma_dev == chan->device->dev) { > - chan->private = sl; > - return true; > - } else { > - return false; > - } > -} I'm wondering why is filtering no longer required? [...] > + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR; [...] > + slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR; Change the type of phybase to dma_addr_t [...] > } > > -static int atmel_pcm_dma_prepare(struct snd_pcm_substream *substream) > -{ > - struct snd_soc_pcm_runtime *rtd = substream->private_data; > - struct atmel_pcm_dma_params *prtd; > - > - prtd = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream); > - > - ssc_writex(prtd->ssc->regs, SSC_IER, prtd->mask->ssc_error); > - ssc_writex(prtd->ssc->regs, SSC_CR, prtd->mask->ssc_enable); These writes are also completely lost > - > - return 0; > -} I think it would also be good to get rid of any references to the ssc struct from the DMA driver and move them over to the DAI driver. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/