Message-ID: <1372797778.1919.17.camel@bwh-desktop.uk.level5networks.com>
Subject: Re: [PATCH v2 net-next] net: convert lls to use time_in_range()
From: Ben Hutchings <bhutchings@solarflare.com>
To: Eliezer Tamir <eliezer.tamir@linux.intel.com>
CC: David Miller <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <willemb@google.com>, <erdnetdev@gmail.com>,
        <andi@firstfloor.org>, <hpa@zytor.com>, <devel-lists@codyps.com>,
        <eliezer@tamir.org.il>
Date: Tue, 2 Jul 2013 21:42:58 +0100
In-Reply-To: <51D337D0.1080901@linux.intel.com>
References: <20130628125918.14419.36214.stgit@ladj378.jer.intel.com>
	  <20130701.140833.1705666564717621661.davem@davemloft.net>
	  <51D2919F.7050007@linux.intel.com> <51D29329.4060004@linux.intel.com>
	  <51D2A246.3000705@linux.intel.com>
	 <1372795835.1919.14.camel@bwh-desktop.uk.level5networks.com>
	 <51D337D0.1080901@linux.intel.com>
Organization: Solarflare
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1338
Lines: 37

On Tue, 2013-07-02 at 23:28 +0300, Eliezer Tamir wrote:
> On 02/07/2013 23:10, Ben Hutchings wrote:
> > On Tue, 2013-07-02 at 12:49 +0300, Eliezer Tamir wrote:
> >> Time in range will fail safely if we move to a different cpu with an
> >> extremely large clock skew.
> >> Add time_in_range64() and convert lls to use it.
> >>
> >> Signed-off-by: Eliezer Tamir <eliezer.tamir@linux.intel.com>
> >> ---
> >> v1->v2
> >> fixed double call to sched_clock() in can_poll_ll(), checkpatchisms
> 
> >> +#define time_in_range64(a, b, c) \
> >> +	(time_after_eq64(a, b) && \
> >> +	 time_before_eq64(a, c))
> > [...]
> >
> > Why not make this an inline function, so the caller doesn't need to
> > worry about repeated evaluation?
> 
> I was following the conventions in jiffies.h
> (well almost, I did add a few spaces to make checkpatch happy)

I see, but now you have a good reason to change that convention.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/