Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932081Ab3GCHdP (ORCPT ); Wed, 3 Jul 2013 03:33:15 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:45798 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754311Ab3GCHdK (ORCPT ); Wed, 3 Jul 2013 03:33:10 -0400 Message-ID: <51D3D482.1050100@metafoo.de> Date: Wed, 03 Jul 2013 09:36:34 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Bo Shen CC: Mark Brown , alsa-devel@alsa-project.org, richard.genoud@gmail.com, Nicolas Ferre , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework References: <1372755849-19546-1-git-send-email-voice.shen@atmel.com> <1372755849-19546-3-git-send-email-voice.shen@atmel.com> <51D2F306.7040603@metafoo.de> <51D37F87.2010008@atmel.com> In-Reply-To: <51D37F87.2010008@atmel.com> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1658 Lines: 48 On 07/03/2013 03:33 AM, Bo Shen wrote: > Hi Lars-Peter, > > On 7/2/2013 23:34, Lars-Peter Clausen wrote: >> On 07/02/2013 11:04 AM, Bo Shen wrote: >> [...] >>> -/*--------------------------------------------------------------------------*\ >>> - * DMAENGINE operations >>> -\*--------------------------------------------------------------------------*/ >>> -static bool filter(struct dma_chan *chan, void *slave) >>> -{ >>> - struct at_dma_slave *sl = slave; >>> - >>> - if (sl->dma_dev == chan->device->dev) { >>> - chan->private = sl; >>> - return true; >>> - } else { >>> - return false; >>> - } >>> -} >> >> I'm wondering why is filtering no longer required? > > Now this is handled by at_dma_filter in at_hdmac driver. More information, you > can reference: file Ok, so the DMA channel is now supplied via devicetree. This is really a change that should be listed in the changelog. > >> [...] >>> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR; >> [...] >>> + slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR; >> >> Change the type of phybase to dma_addr_t > > It should be: > slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR); > slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR); The type of phybase in the ssc_device struct should be changed from resource_size_t to dma_addr_t. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/