Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754712Ab3GCH6W (ORCPT ); Wed, 3 Jul 2013 03:58:22 -0400 Received: from nasmtp02.atmel.com ([204.2.163.16]:46253 "EHLO nasmtp02.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754089Ab3GCH6V (ORCPT ); Wed, 3 Jul 2013 03:58:21 -0400 Message-ID: <51D3D969.1060308@atmel.com> Date: Wed, 3 Jul 2013 15:57:29 +0800 From: Bo Shen User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Lars-Peter Clausen CC: Mark Brown , , , Nicolas Ferre , , , Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework References: <1372755849-19546-1-git-send-email-voice.shen@atmel.com> <1372755849-19546-3-git-send-email-voice.shen@atmel.com> <51D2F306.7040603@metafoo.de> <51D37F87.2010008@atmel.com> <51D3D482.1050100@metafoo.de> In-Reply-To: <51D3D482.1050100@metafoo.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 27 Hi Lars, On 7/3/2013 15:36, Lars-Peter Clausen wrote: >>>> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR; >>> >>[...] >>>> >>>+ slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR; >>> >> >>> >>Change the type of phybase to dma_addr_t >> > >> >It should be: >> >slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR); >> >slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR); > The type of phybase in the ssc_device struct should be changed from > resource_size_t to dma_addr_t. Actually, the phybase in ssc_device structure is resource_size_t which used to access the ssc device register. Here, we use ssc register as dma source address or destination address, so we convert it to dma_addr_t type. So, not need to change, am I right? Best Regards, Bo Shen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/