Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 7 Oct 2002 14:57:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 7 Oct 2002 14:57:03 -0400 Received: from pizda.ninka.net ([216.101.162.242]:924 "EHLO pizda.ninka.net") by vger.kernel.org with ESMTP id ; Mon, 7 Oct 2002 14:57:01 -0400 Date: Mon, 07 Oct 2002 11:55:30 -0700 (PDT) Message-Id: <20021007.115530.00078126.davem@redhat.com> To: yoshfuji@linux-ipv6.org Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com, usagi@linux-ipv6.org Subject: Re: [PATCH] IPv6: Fix Prefix Length of Link-local Addresses From: "David S. Miller" In-Reply-To: <20021008.000559.17528416.yoshfuji@linux-ipv6.org> References: <20021008.000559.17528416.yoshfuji@linux-ipv6.org> X-FalunGong: Information control. X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 35 From: YOSHIFUJI Hideaki / 吉藤英明 Date: Tue, 08 Oct 2002 00:05:59 +0900 (JST) Prefix length for link-local address should be 64, not 10. This patch fixes prefix length of link-local address. Following patch is against 2.4.19. Patch is applied, thank you. BTW, we start to run into conflicts now and most of USAGI patches now I need to apply some parts by hand. Here is one example, with this patch: @@ -783,7 +783,7 @@ struct in6_addr addr; ipv6_addr_set(&addr, __constant_htonl(0xFE800000), 0, 0, 0); - addrconf_prefix_route(&addr, 10, dev, 0, RTF_ADDRCONF); + addrconf_prefix_route(&addr, 64, dev, 0, RTF_ADDRCONF); } static struct inet6_dev *addrconf_add_dev(struct net_device *dev) Note in this hunk the __constant_htonl() which was transformed to plain htonl() by already accepted USAGI patch. It is not such a big deal now, but it may soon become larger as bigger USAGI patches are applied. We will need to synchronize at some point. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/