Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755123Ab3GCVqN (ORCPT ); Wed, 3 Jul 2013 17:46:13 -0400 Received: from mail-oa0-f42.google.com ([209.85.219.42]:63576 "EHLO mail-oa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969Ab3GCVqL (ORCPT ); Wed, 3 Jul 2013 17:46:11 -0400 MIME-Version: 1.0 In-Reply-To: <1372860295-8306-7-git-send-email-mika.westerberg@linux.intel.com> References: <1372860295-8306-1-git-send-email-mika.westerberg@linux.intel.com> <1372860295-8306-7-git-send-email-mika.westerberg@linux.intel.com> From: Bjorn Helgaas Date: Wed, 3 Jul 2013 15:45:50 -0600 Message-ID: Subject: Re: [PATCH v2 6/8] PCI: acpiphp: workaround for Thunderbolt on Acer Aspire S5 To: Mika Westerberg Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Jesse Barnes , Yinghai Lu , "Ronciak, John" , "Penner, Miles J" , Bruce Allan , Heikki Krogerus , "Kirill A. Shutemov" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-pci@vger.kernel.org" , "x86@kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2450 Lines: 75 On Wed, Jul 3, 2013 at 8:04 AM, Mika Westerberg wrote: > From: "Kirill A. Shutemov" > > Correct ACPI PCI hotplug imeplementation should have _RMV method in a > PCI slot (device under pci bridge). In Acer Aspire S5 case we have it > deeper in hierarchy: > > Device (RP05) > { > // ... > Device (HRUP) > { > // ... > Device (HRDN) > { > // ... > Device (EPUP) > { > // ... > Method (_RMV, 0, NotSerialized) // _RMV: Removal Status > { > Return (One) > } > } > } > } > } > > Signed-off-by: Kirill A. Shutemov > Signed-off-by: Mika Westerberg > --- > drivers/pci/hotplug/acpi_pcihp.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c > index 2a47e82..d92ebfb 100644 > --- a/drivers/pci/hotplug/acpi_pcihp.c > +++ b/drivers/pci/hotplug/acpi_pcihp.c > @@ -422,6 +422,19 @@ static int pcihp_is_ejectable(acpi_handle handle) > status = acpi_evaluate_integer(handle, "_RMV", NULL, &removable); > if (ACPI_SUCCESS(status) && removable) > return 1; > + > + /* > + * Workaround for Thunderbolt implementation on Acer Aspire S5. > + * > + * Correct ACPI PCI hotplug imeplementation has _RMV method in a PCI > + * slot (device under pci bridge). In Acer Aspire S5 case we have it > + * deeper in hierarchy. s/imeplementation/implementation/ If you're casting aspersions on Acer for having an incorrect ACPI implementation, you should probably provide a spec reference. I think it's likely that the Acer implementation is actually correct per the spec, but Linux just isn't smart enough to handle it. > + */ > + status = acpi_evaluate_integer(handle, "HRDN.EPUP._RMV", NULL, > + &removable); > + if (ACPI_SUCCESS(status) && removable) > + return 1; > + > return 0; > } > > -- > 1.8.3.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/