Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756499Ab3GDJEF (ORCPT ); Thu, 4 Jul 2013 05:04:05 -0400 Received: from mail-oa0-f49.google.com ([209.85.219.49]:51082 "EHLO mail-oa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756409Ab3GDJED (ORCPT ); Thu, 4 Jul 2013 05:04:03 -0400 MIME-Version: 1.0 In-Reply-To: <20130702200147.GC9359@redhat.com> References: <1372696755-17427-1-git-send-email-dvlasenk@redhat.com> <20130702200147.GC9359@redhat.com> From: Denys Vlasenko Date: Thu, 4 Jul 2013 11:03:41 +0200 Message-ID: Subject: Re: [PATCH] Define WTERMSIG{,_MASK} and WCOREDUMP and use where appropriate To: Oleg Nesterov Cc: Denys Vlasenko , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 21 On Tue, Jul 2, 2013 at 10:01 PM, Oleg Nesterov wrote: > On 07/01, Denys Vlasenko wrote: >> >> Grepping for numeric constants is inconvenient. > > Personally I agree very much, and I like the intent. > >> +#define WTERMSIG_MASK 0x7f >> +#define WTERMSIG(status) ((status) & WTERMSIG_MASK) >> +#define WCOREDUMP(status) ((status) & 0x80) > > But I am not sure we need WTERMSIG/WCOREDUMP helpers, although > I won't really argue. Are you saying that you prefer just mask constants, do not want macros? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/