Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756856Ab3GDRTz (ORCPT ); Thu, 4 Jul 2013 13:19:55 -0400 Received: from filtteri2.pp.htv.fi ([213.243.153.185]:35291 "EHLO filtteri2.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756777Ab3GDRTx (ORCPT ); Thu, 4 Jul 2013 13:19:53 -0400 Date: Thu, 4 Jul 2013 20:19:39 +0300 From: Aaro Koskinen To: Pavel Machek Cc: Tony Lindgren , b-cousson@ti.com, pali.rohar@gmail.com, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org Subject: Re: [PATCH] N900: add device tree Message-ID: <20130704171939.GA27374@blackmetal.musicnaut.iki.fi> References: <20130613141001.GF8164@atomide.com> <20130613142809.GA3775@amd.pavel.ucw.cz> <20130613145724.GH8164@atomide.com> <20130613155240.GB3775@amd.pavel.ucw.cz> <20130613161418.GJ8164@atomide.com> <20130613230808.GA14876@amd.pavel.ucw.cz> <20130614055629.GM8164@atomide.com> <20130614212816.GA31768@atrey.karlin.mff.cuni.cz> <20130617111031.GQ20992@atomide.com> <20130701211753.GC15318@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130701211753.GC15318@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 25 On Mon, Jul 01, 2013 at 11:17:54PM +0200, Pavel Machek wrote: > This adds device tree with neccessary support to boot with functional > video (on both emulator and real N900 device). Is this really correct? You have commented out the USB, so there is no way for a developer to interact with the device. Some minor issue too: > +/* > + * Copyright (C) 2013 Pavel Machek > + * Copyright 2013 Aaro Koskinen > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 (or later) as > + * published by the Free Software Foundation. Should be just GPLv2. A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/