Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756976Ab3GDWDY (ORCPT ); Thu, 4 Jul 2013 18:03:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28410 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756902Ab3GDWDX (ORCPT ); Thu, 4 Jul 2013 18:03:23 -0400 Date: Fri, 5 Jul 2013 00:02:33 +0200 From: Jiri Olsa To: Peter Zijlstra Cc: Vince Weaver , linux-kernel@vger.kernel.org, Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Stephane Eranian , Greg Kroah-Hartman , Andi Kleen Subject: Re: perf/Documentation/ABI -- add some documentation for perf_event sysfs usage Message-ID: <20130704220233.GA11319@krava.redhat.com> References: <20130704090253.GJ18898@dyad.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130704090253.GJ18898@dyad.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1711 Lines: 47 On Thu, Jul 04, 2013 at 11:02:53AM +0200, Peter Zijlstra wrote: > On Wed, Jul 03, 2013 at 11:14:40PM -0400, Vince Weaver wrote: > > On Wed, 3 Jul 2013, Vince Weaver wrote: > > > OK, don't I feel silly, these values were already documented in > > Documentation/ABI/testing/sysfs-bus-event_source-devices-events > > rather than ABI/stable > > > > To be fair I missed it because the documentation seemed to come from the > > Power developers and not through perf_event > > > > anyway, that documentation says the values will be hex only, which was > > broken by > > > > commit f9134f36aed59ab55c0ab1a4618dd455f15aef5f > > Author: Andi Kleen > > Date: Mon Jun 17 17:36:52 2013 -0700 > > > > perf/x86/intel: Add mem-loads/stores support for Haswell > > > > > > which added: > > EVENT_ATTR_STR(mem-loads, mem_ld_hsw, "event=0xcd,umask=0x1,ldlat=3"); > > > > (note ldlat is not in hex). > > > > This broke the trinity fuzzer (which scans to look for events to use) > > as well as some of my personal tools. > > > > Should the ldlat value be fixed to be hex? Or should we ammend the ABI > > document to allow decimal? > > I don't see a good reason not to allow decimal as well. Jolsa? yep, no technical problem with decimal hum, the doc mentions 'event' term only, which IS hex only AFAICS ;-) I think this docs should be updated and either describe all allowed terms or be generic enough to cover all of them. jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/