Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757391Ab3GEOXg (ORCPT ); Fri, 5 Jul 2013 10:23:36 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:58927 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752356Ab3GEOXf (ORCPT ); Fri, 5 Jul 2013 10:23:35 -0400 MIME-Version: 1.0 In-Reply-To: <20130704075840.GH18898@dyad.programming.kicks-ass.net> References: <1372916056-24301-1-git-send-email-alex.shi@intel.com> <20130704075840.GH18898@dyad.programming.kicks-ass.net> Date: Fri, 5 Jul 2013 16:23:33 +0200 Message-ID: Subject: Re: [URGENT rfc patch 0/3] tsc clocksource bug fix From: Frederic Weisbecker To: Peter Zijlstra Cc: Alex Shi , tglx@linutronix.de, hpa@linux.intel.com, tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org, andi.kleen@intel.com, mingo@elte.hu Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 954 Lines: 22 2013/7/4 Peter Zijlstra : > On Thu, Jul 04, 2013 at 01:34:13PM +0800, Alex Shi wrote: > >> If the tsc is marked as constant and nonstop, could we set it as system >> clocksource when do tsc register? w/o checking it on clocksource_watchdog? > > I'd not do that; the BIOS can still screw you over, we need some validation. > > That said; we do need means to disable the clocksource watchdog -- although I > suppose Frederic might already have provided this for this NOHZ efforts when I > wasn't looking. Nope, I haven't touched that. I prefer not to fiddle with unstable clocksource for now :) As for unstable TSCs, if sched_clock_tick() needs to be fed, we simply don't stop the tick. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/