Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964839Ab3GEQ5F (ORCPT ); Fri, 5 Jul 2013 12:57:05 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:45591 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756988Ab3GEQ5E (ORCPT ); Fri, 5 Jul 2013 12:57:04 -0400 Date: Fri, 5 Jul 2013 09:57:01 -0700 From: Stephen Boyd To: Gregory CLEMENT Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-arm-kernel@infradead.org, arm@kernel.org Subject: Re: [PATCH 1/8] clocksource: armada-xp: always register local_timer_ops Message-ID: <20130705165701.GI11625@codeaurora.org> References: <1373041417-217728-1-git-send-email-arnd@arndb.de> <1373041417-217728-2-git-send-email-arnd@arndb.de> <51D6F554.3070702@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51D6F554.3070702@free-electrons.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2299 Lines: 55 On 07/05, Gregory CLEMENT wrote: > On 07/05/2013 06:23 PM, Arnd Bergmann wrote: > > The call to local_timer_register is hidden behind an #ifdef, which > > turns the armada_370_xp_local_timer_ops into a potentially unused > > variable, causing this warning: > > > > time-armada-370-xp.c:208:31: warning: 'armada_370_xp_local_timer_ops' defined but not used [-Wunused-variable] > > static struct local_timer_ops armada_370_xp_local_timer_ops __cpuinitdata = { > > ^ > > > > Since local_timer_register() itself doesn't do anything, just removing > > the #ifdef makes the code look nicer and gets rid of the warning. > > > > Signed-off-by: Arnd Bergmann > > Acked-by: Jason Cooper > > Cc: Gregory CLEMENT > > --- > > drivers/clocksource/time-armada-370-xp.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c > > index 47a6730..4cd8520 100644 > > --- a/drivers/clocksource/time-armada-370-xp.c > > +++ b/drivers/clocksource/time-armada-370-xp.c > > @@ -294,8 +294,6 @@ void __init armada_370_xp_timer_init(void) > > percpu_armada_370_xp_evt); > > if (!res) { > > enable_percpu_irq(armada_370_xp_clkevt.irq, 0); > > -#ifdef CONFIG_LOCAL_TIMERS > > local_timer_register(&armada_370_xp_local_timer_ops); > > -#endif > > } > > } > > > > I thought this issue was kind of fixed by the patch > "clocksource: time-armada-370-xp: Divorce from local timer API" from Stephen Boyd. > > But I can't find it in linux-next so maybe it has not been pulled, so in this case > you can also add my > Acked-by: Gregory CLEMENT > The pull request is blocked on Thomas responding about timers/core being a stable branch. We may just have to wait until timers/core goes in before Arnd and Olof can take it in. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/