Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423Ab3GGOUX (ORCPT ); Sun, 7 Jul 2013 10:20:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60771 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289Ab3GGOUT (ORCPT ); Sun, 7 Jul 2013 10:20:19 -0400 Date: Sun, 7 Jul 2013 17:21:20 +0300 From: "Michael S. Tsirkin" To: kvm@vger.kernel.org Cc: Rusty Russell , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio: include asm/barrier explicitly Message-ID: <20130707142120.GA2465@redhat.com> References: <20130707142019.GA2447@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130707142019.GA2447@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1623 Lines: 44 On Sun, Jul 07, 2013 at 05:20:19PM +0300, Michael S. Tsirkin wrote: > virtio_ring.h uses mb() and friends, make > it pull in asm/barrier.h itself, not rely > on other headers to do it. > > Signed-off-by: Michael S. Tsirkin In particular this fixes warnings during test build: [linux]$ make -C tools/virtio/ make: Entering directory `/home/mst/scm/linux/tools/virtio' cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign -fno-strict-overflow -fno-strict-aliasing -fno-common -MMD -U_FORTIFY_SOURCE -c -o virtio_test.o virtio_test.c In file included from ./linux/virtio_ring.h:1:0, from ../../usr/include/linux/vhost.h:17, from virtio_test.c:14: ./linux/../../../include/linux/virtio_ring.h: In function ‘virtio_mb’: ./linux/../../../include/linux/virtio_ring.h:50:2: warning: implicit declaration of function ‘mb’ [-Wimplicit-function-declaration] > --- > include/linux/virtio_ring.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h > index ca3ad41..b300787 100644 > --- a/include/linux/virtio_ring.h > +++ b/include/linux/virtio_ring.h > @@ -1,6 +1,7 @@ > #ifndef _LINUX_VIRTIO_RING_H > #define _LINUX_VIRTIO_RING_H > > +#include > #include > #include > > -- > MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/