Date: Sun, 7 Jul 2013 16:56:04 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
        Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        Stephane Eranian <eranian@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: perf/Documentation/ABI -- add some documentation for perf_event
 sysfs usage
Message-ID: <20130707145604.GD23433@krava.brq.redhat.com>
References: <alpine.DEB.2.10.1307031527390.12584@vincent-weaver-1.um.maine.edu>
 <alpine.DEB.2.10.1307032308040.13409@vincent-weaver-1.um.maine.edu>
 <20130704090253.GJ18898@dyad.programming.kicks-ass.net>
 <20130704220233.GA11319@krava.redhat.com>
 <alpine.DEB.2.10.1307051119410.27475@vincent-weaver-1.um.maine.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1307051119410.27475@vincent-weaver-1.um.maine.edu>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2464
Lines: 61

On Fri, Jul 05, 2013 at 11:28:08AM -0400, Vince Weaver wrote:
> On Fri, 5 Jul 2013, Jiri Olsa wrote:
> 
> > On Thu, Jul 04, 2013 at 11:02:53AM +0200, Peter Zijlstra wrote:
> > > On Wed, Jul 03, 2013 at 11:14:40PM -0400, Vince Weaver wrote:
> 
> > > >    Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> > > > 
> > > > Should the ldlat value be fixed to be hex?  Or should we ammend the ABI
> > > > document to allow decimal?
> > > 
> > > I don't see a good reason not to allow decimal as well. Jolsa?
> > 
> > yep, no technical problem with decimal
> > 
> > hum, the doc mentions 'event' term only, which IS hex only AFAICS ;-)
> > 
> > I think this docs should be updated and either describe all
> > allowed terms or be generic enough to cover all of them.
> 
> So you're saying the official kernel ABI should be "whatever the 
> userspace perf tool happens to accept"?

nope, I meant whatever term is used by kernel to describe the event

'event, umask, edge, pc, any, inv, cmask, ldat'

please check x86_event_sysfs_show function

> 
> That's not really useful, especially as perf doesn't distinguish between
> event strings read from sysfs and those passed on the perf command line.
> The ABI documentation in effect ends up being a pointer to a mostly 
> incomprehensible lex/yacc file.

the documentation is missing, no argument here :-\
'sysfs-bus-event_source-devices-events' could be more descriptive

> 
> I think we should just remove the 
>    Documentation/ABI/testing/sysfs-bus-event_source-devices-events
> file as it's misleading.  Userspace broke and no one cares.
> 
> It's not even easy to audit all places in the kernel that create the sysfs 
> event files because each architecture does it differently.  And there's no 
> sane way to unit test this on a new kernel release because the values 
> printed depend on the hardware you have, so without a full range of all 
> families of cpus for all architectures you never know when someone has 
> added a decimal value, or started depending on { characters, etc.
> 
> This is the problem with perf in the tools directory, any other user of 
> the ABI is eternally second-class.

with updated documentation I dont see the issue

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/