Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753620Ab3GHFVK (ORCPT ); Mon, 8 Jul 2013 01:21:10 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:32770 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753531Ab3GHFVI (ORCPT ); Mon, 8 Jul 2013 01:21:08 -0400 Message-ID: <51DA4C23.6050604@ti.com> Date: Mon, 8 Jul 2013 10:50:35 +0530 From: George Cherian User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: CC: , , , , , , Subject: Re: [PATCH] arm: dts: AM43x: Add usb_otg_hs node References: <1372401887-19422-1-git-send-email-george.cherian@ti.com> <20130707083558.GA12992@arwen.pp.htv.fi> In-Reply-To: <20130707083558.GA12992@arwen.pp.htv.fi> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1627 Lines: 46 On 7/7/2013 2:05 PM, Felipe Balbi wrote: > Hi, > > On Fri, Jun 28, 2013 at 12:14:47PM +0530, George Cherian wrote: >> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi >> index ddc1df7..e4f5eb8 100644 >> --- a/arch/arm/boot/dts/am4372.dtsi >> +++ b/arch/arm/boot/dts/am4372.dtsi >> @@ -64,5 +64,24 @@ >> compatible = "ti,am4372-counter32k","ti,omap-counter32k"; >> reg = <0x44e86000 0x40>; >> }; >> + >> + usb_otg_hs1: am4372_dwc3@48380000 { >> + compatible = "ti,am437x-dwc3"; >> + reg = <0x48380000 0x1ff>; >> + interrupts = ; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + utmi-mode = <1>; >> + ranges; >> + >> + dwc3@48390000 { >> + compatible = "synopsys,dwc3"; > let's us snps,dwc3. I recently posted a patch converting synopsys to > snps like all other DesignWare drivers. Support for synopsys,dwc3 is > still there, but shouldn't be used. okay > >> + reg = <0x48390000 0xcfff>; >> + interrupts = ; >> + tx-fifo-resize; > is this flag *really* necessary, I asked you and didn't get an answer. We will not be needing this flag , since each EP has 3K tx fifo size. Also given the fact that we will be operating only in 2.0 mode the default values are only sufficient. I will re-send the patch with above changes. Regards, -George -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/