Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894Ab3GHNO0 (ORCPT ); Mon, 8 Jul 2013 09:14:26 -0400 Received: from mail-pb0-f65.google.com ([209.85.160.65]:57077 "EHLO mail-pb0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213Ab3GHNOY (ORCPT ); Mon, 8 Jul 2013 09:14:24 -0400 Date: Mon, 8 Jul 2013 06:14:21 -0700 From: Guenter Roeck To: Wei Ni Cc: Jean Delvare , "linux@arm.linux.org.uk" , Stephen Warren , "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" , Matthew Longnecker , Alex Courbot , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [lm-sensors] [PATCH 1/2] ARM: dt: t30 cardhu: add dt entry for lm90 Message-ID: <20130708131421.GB21638@roeck-us.net> References: <1372928979-26938-1-git-send-email-wni@nvidia.com> <1372928979-26938-2-git-send-email-wni@nvidia.com> <51D70483.70203@wwwdotorg.org> <51DA6BD4.1040300@nvidia.com> <20130708095024.041a6d57@endymion.delvare> <51DA8805.50709@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51DA8805.50709@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1812 Lines: 46 On Mon, Jul 08, 2013 at 05:36:05PM +0800, Wei Ni wrote: > On 07/08/2013 03:50 PM, Jean Delvare wrote: > > On Mon, 8 Jul 2013 15:35:48 +0800, Wei Ni wrote: > >> On 07/06/2013 01:38 AM, Stephen Warren wrote: > >>> On 07/04/2013 03:09 AM, Wei Ni wrote: > >>>> Enable thermal sensor lm90 for t30 cardhu. > >>> > >>>> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi > >>> > >>>> + nct1008: nct1008 { > >>>> + compatible = "lm90,nct1008"; > >>> > >>> "lm90" isn't a valid vendor prefix. I believe the value you want is > >>> "onnn,nct1008". Same comment for patch 2/2. > >> > >> The lm90 doesn't support device tree very well. > > > > I doubt it, but if this is the case, then please fix it, instead of > > working the problem around in a different place. > > > >> In the DT, we need to > >> named as "lm90" so that the lm90 driver can be loaded, > > > > Not that I am an expert with regards to DT, but this doesn't make any > > sense to me. AFAIK DT is about devices, not which drivers handle them. > > > >> and we also need > >> to add "nct1008" to indicate this is the nct1008 device, so that the > >> lm90 driver can be loaded with the right i2c_device_id->driver_data. > >> > >> I set the " compatible = "lm90,nct1008" ", this is the simplest way, and > >> we doesn't need to change the lm90.c. > > > > There's no problem with changing the lm90 driver, if this is the right > > thing to do. > > Ok, I will add DT support in the lm90.c in my next version patch. > Only if you can show that it is necessary. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/