Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752579Ab3GHNv2 (ORCPT ); Mon, 8 Jul 2013 09:51:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40286 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760Ab3GHNv1 (ORCPT ); Mon, 8 Jul 2013 09:51:27 -0400 Date: Mon, 8 Jul 2013 15:50:48 +0200 From: Jiri Olsa To: Peter Zijlstra Cc: Vince Weaver , linux-kernel@vger.kernel.org, Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , trinity@vger.kernel.org Subject: Re: [bisected] perf: yet another fuzzer triggered crash Message-ID: <20130708135048.GA1069@krava.brq.redhat.com> References: <20130701090713.GO6626@twins.programming.kicks-ass.net> <20130703074929.GE23916@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130703074929.GE23916@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 54 On Wed, Jul 03, 2013 at 09:49:29AM +0200, Peter Zijlstra wrote: > On Tue, Jul 02, 2013 at 11:15:59PM -0400, Vince Weaver wrote: > > > > OK, I have bisected this problem to the following change: > > > > commit 8dc85d547285668e509f86c177bcd4ea055bcaaf > > Author: Peter Zijlstra > > Date: Thu Sep 2 16:50:03 2010 +0200 > > > > perf: Multiple task contexts > > > > Provide the infrastructure for multiple task contexts. > > > > Thanks, that narrows down the scope a bit. As it happens I was also > narrowing down on that particular area so that's good. > hi, patch below gets rid of the warning, and probably the crash as well the reason seems to be when HW context is cloned based on SW event that happened to get there because of the HW leader, which got closed just before (fd[15] event in the reproducer) and the consequence is that in HW context we access SW's cpuctx -> and thus overwriting its task_ctx variable any time there's *sched_in routine need to check if that does not break anything else ;-) jirka --- diff --git a/kernel/events/core.c b/kernel/events/core.c index 1833bc5..1d1f030 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -7465,7 +7465,7 @@ inherit_task_group(struct perf_event *event, struct task_struct *parent, * child. */ - child_ctx = alloc_perf_context(event->pmu, child); + child_ctx = alloc_perf_context(parent_ctx->pmu, child); if (!child_ctx) return -ENOMEM; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/